bpo-5755: don't compile extensions with -Wstrict-prototypes

jdemeyer · jdemeyer · commit a49fdcbb96fe · 2018-05-15T23:38:37.000+02:00
diff --git a/Misc/NEWS.d/next/Build/2018-05-14-11-57-56.bpo-5755.kpNUx-.rst b/Misc/NEWS.d/next/Build/2018-05-14-11-57-56.bpo-5755.kpNUx-.rst
@@ -0,0 +1,3 @@
+No longer use the ``-Wstrict-prototypes`` compiler flag.
+This avoids a compiler warning when compiling C++ extension modules
+with distutils.
diff --git a/configure b/configure
@@ -6678,9 +6678,6 @@ if test "${OPT-unset}" = "unset"
 then
     case $GCC in
     yes)
-        if test "$CC" != 'g++' ; then
-	    STRICT_PROTO="-Wstrict-prototypes"
-	fi
         # For gcc 4.x we need to use -fwrapv so lets check if its supported
         if "$CC" -v --help 2>/dev/null |grep -- -fwrapv > /dev/null; then
            WRAP="-fwrapv"
@@ -6727,8 +6724,6 @@ then
 	    ;;
 	esac
 
-	OPT="$OPT $STRICT_PROTO"
-
 	case $ac_sys_system in
 	    SCO_SV*) OPT="$OPT -m486 -DSCO5"
 	    ;;
diff --git a/configure.ac b/configure.ac
@@ -1421,9 +1421,6 @@ if test "${OPT-unset}" = "unset"
 then
     case $GCC in
     yes)
-        if test "$CC" != 'g++' ; then
-	    STRICT_PROTO="-Wstrict-prototypes"
-	fi
         # For gcc 4.x we need to use -fwrapv so lets check if its supported
         if "$CC" -v --help 2>/dev/null |grep -- -fwrapv > /dev/null; then
            WRAP="-fwrapv"
@@ -1470,8 +1467,6 @@ then
 	    ;;
 	esac
 
-	OPT="$OPT $STRICT_PROTO"
-
 	case $ac_sys_system in
 	    SCO_SV*) OPT="$OPT -m486 -DSCO5"
 	    ;;

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	+No longer use the ``-Wstrict-prototypes`` compiler flag.
	`2`	`+This avoids a compiler warning when compiling C++ extension modules`
	`3`	`+with distutils.`