Enhance tests

vstinner · vstinner · commit 93f84ade2030 · 2023-11-14T00:03:34.000+01:00
diff --git a/Modules/_testcapi/dict.c b/Modules/_testcapi/dict.c
@@ -347,9 +347,13 @@ dict_pop(PyObject *self, PyObject *args)
         assert(result == NULL);
         return NULL;
     }
-    if (result == NULL) {
+    if (res == 0) {
+        assert(result == NULL);
         result = Py_NewRef(Py_None);
     }
+    else {
+        assert(result != NULL);
+    }
     return Py_BuildValue("iN", res, result);
 }
 
@@ -388,9 +392,13 @@ dict_popstring(PyObject *self, PyObject *args)
         assert(result == NULL);
         return NULL;
     }
-    if (result == NULL) {
+    if (res == 0) {
+        assert(result == NULL);
         result = Py_NewRef(Py_None);
     }
+    else {
+        assert(result != NULL);
+    }
     return Py_BuildValue("iN", res, result);
 }
 

Original file line number	Diff line number	Diff line change
`@@ -347,9 +347,13 @@ dict_pop(PyObject self, PyObject args)`
`347`	`347`	`assert(result == NULL);`
`348`	`348`	`return NULL;`
`349`	`349`	`}`
`350`		`- if (result == NULL) {`
	`350`	`+ if (res == 0) {`
	`351`	`+ assert(result == NULL);`
`351`	`352`	`result = Py_NewRef(Py_None);`
`352`	`353`	`}`
	`354`	`+ else {`
	`355`	`+ assert(result != NULL);`
	`356`	`+ }`
`353`	`357`	`return Py_BuildValue("iN", res, result);`
`354`	`358`	`}`
`355`	`359`
`@@ -388,9 +392,13 @@ dict_popstring(PyObject self, PyObject args)`
`388`	`392`	`assert(result == NULL);`
`389`	`393`	`return NULL;`
`390`	`394`	`}`
`391`		`- if (result == NULL) {`
	`395`	`+ if (res == 0) {`
	`396`	`+ assert(result == NULL);`
`392`	`397`	`result = Py_NewRef(Py_None);`
`393`	`398`	`}`
	`399`	`+ else {`
	`400`	`+ assert(result != NULL);`
	`401`	`+ }`
`394`	`402`	`return Py_BuildValue("iN", res, result);`
`395`	`403`	`}`
`396`	`404`