Drop confusing commented out code in pystrtod.c (GH-6072) (GH-9588)

vstinner · web-flow · commit 911231e70843 · 2018-09-26T08:18:23.000-07:00
Fix the following warning: Python/pystrtod.c: In function 'format_float_short': Python/pystrtod.c:1007:13: warning: 'strncpy' output truncated before terminating nul copying 3 bytes from a string of the same length [-Wstringop-truncation] strncpy(p, "ERR", 3); (cherry picked from commit 9fb8415)
diff --git a/Python/pystrtod.c b/Python/pystrtod.c
@@ -1004,8 +1004,6 @@ format_float_short(double d, char format_code,
         else {
             /* shouldn't get here: Gay's code should always return
                something starting with a digit, an 'I',  or 'N' */
-            strncpy(p, "ERR", 3);
-            p += 3;
             assert(0);
         }
         goto exit;

Original file line number	Diff line number	Diff line change
`@@ -1004,8 +1004,6 @@ format_float_short(double d, char format_code,`
`1004`	`1004`	`else {`
`1005`	`1005`	`/* shouldn't get here: Gay's code should always return`
`1006`	`1006`	`something starting with a digit, an 'I', or 'N' */`
`1007`		`- strncpy(p, "ERR", 3);`
`1008`		`- p += 3;`
`1009`	`1007`	`assert(0);`
`1010`	`1008`	`}`
`1011`	`1009`	`goto exit;`