gh-144493: Improve error message in _overlapped.BindLocal() (#144495)

dlech · web-flow · commit 56590f820e94 · 2026-02-06T09:51:19.000+01:00
Replace a confusing error message with one that actually explains what the error is in `_overlapped.BindLocal()`. Fixes: #144493
diff --git a/Misc/NEWS.d/next/Library/2026-02-05-17-15-31.gh-issue-144493.XuxwVu.rst b/Misc/NEWS.d/next/Library/2026-02-05-17-15-31.gh-issue-144493.XuxwVu.rst
@@ -0,0 +1 @@
+Improve an exception error message in ``_overlapped.BindLocal()`` that is raised when :meth:`asyncio.loop.sock_connect` is called on a :class:`asyncio.ProactorEventLoop` with a socket that has an invalid address family.
diff --git a/Modules/overlapped.c b/Modules/overlapped.c
@@ -559,7 +559,7 @@ _overlapped_BindLocal_impl(PyObject *module, HANDLE Socket, int Family)
         ret = bind((SOCKET)Socket, (SOCKADDR*)&addr, sizeof(addr))
                 != SOCKET_ERROR;
     } else {
-        PyErr_SetString(PyExc_ValueError, "expected tuple of length 2 or 4");
+        PyErr_SetString(PyExc_ValueError, "Only AF_INET and AF_INET6 families are supported");
         return NULL;
     }
 

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	+Improve an exception error message in ``_overlapped.BindLocal()`` that is raised when :meth:`asyncio.loop.sock_connect` is called on a :class:`asyncio.ProactorEventLoop` with a socket that has an invalid address family.
Original file line number	Diff line number	Diff line change
`@@ -559,7 +559,7 @@ _overlapped_BindLocal_impl(PyObject *module, HANDLE Socket, int Family)`
`559`	`559`	`ret = bind((SOCKET)Socket, (SOCKADDR*)&addr, sizeof(addr))`
`560`	`560`	`!= SOCKET_ERROR;`
`561`	`561`	`} else {`
`562`		`- PyErr_SetString(PyExc_ValueError, "expected tuple of length 2 or 4");`
	`562`	`+ PyErr_SetString(PyExc_ValueError, "Only AF_INET and AF_INET6 families are supported");`
`563`	`563`	`return NULL;`
`564`	`564`	`}`
`565`	`565`