bpo-30567: Fix refleak in sys.getwindowsversion (#1940)

segevfiner · serhiy-storchaka · commit 48fb766f70d9 · 2017-06-04T20:52:27.000+03:00
diff --git a/Python/sysmodule.c b/Python/sysmodule.c
@@ -973,10 +973,10 @@ sys_getwindowsversion(PyObject *self)
         }
         PyMem_RawFree(verblock);
     }
-    PyStructSequence_SET_ITEM(version, pos++, PyTuple_Pack(3,
-        PyLong_FromLong(realMajor),
-        PyLong_FromLong(realMinor),
-        PyLong_FromLong(realBuild)
+    PyStructSequence_SET_ITEM(version, pos++, Py_BuildValue("(kkk)",
+        realMajor,
+        realMinor,
+        realBuild
     ));
 
     if (PyErr_Occurred()) {

Original file line number	Diff line number	Diff line change
`@@ -973,10 +973,10 @@ sys_getwindowsversion(PyObject *self)`
`973`	`973`	`}`
`974`	`974`	`PyMem_RawFree(verblock);`
`975`	`975`	`}`
`976`		`- PyStructSequence_SET_ITEM(version, pos++, PyTuple_Pack(3,`
`977`		`- PyLong_FromLong(realMajor),`
`978`		`- PyLong_FromLong(realMinor),`
`979`		`- PyLong_FromLong(realBuild)`
	`976`	`+ PyStructSequence_SET_ITEM(version, pos++, Py_BuildValue("(kkk)",`
	`977`	`+ realMajor,`
	`978`	`+ realMinor,`
	`979`	`+ realBuild`
`980`	`980`	`));`
`981`	`981`
`982`	`982`	`if (PyErr_Occurred()) {`