gh-105396: Deprecate PyImport_ImportModuleNoBlock() function (#105397)

vstinner · web-flow · commit 3e525d22128c · 2023-06-09T10:30:57.000+02:00
Deprecate the PyImport_ImportModuleNoBlock() function which is just
an alias to PyImport_ImportModule() since Python 3.3.
diff --git a/Doc/c-api/import.rst b/Doc/c-api/import.rst
@@ -38,6 +38,9 @@ Importing Modules
       to per-module locks for most purposes, so this function's special
       behaviour isn't needed anymore.
 
+   .. deprecated-removed:: 3.13 3.15
+      Use :c:func:`PyImport_ImportModule` instead.
+
 
 .. c:function:: PyObject* PyImport_ImportModuleEx(const char *name, PyObject *globals, PyObject *locals, PyObject *fromlist)
 
diff --git a/Doc/whatsnew/3.13.rst b/Doc/whatsnew/3.13.rst
@@ -407,6 +407,11 @@ Deprecated
 
   (Contributed by Victor Stinner in :gh:`105145`.)
 
+* Deprecate the :c:func:`PyImport_ImportModuleNoBlock` function which is just
+  an alias to :c:func:`PyImport_ImportModule` since Python 3.3.
+  Scheduled for removal in Python 3.15.
+  (Contributed by Victor Stinner in :gh:`105396`.)
+
 Removed
 -------
 
diff --git a/Include/import.h b/Include/import.h
@@ -46,7 +46,7 @@ PyAPI_FUNC(PyObject *) PyImport_AddModule(
 PyAPI_FUNC(PyObject *) PyImport_ImportModule(
     const char *name            /* UTF-8 encoded string */
     );
-PyAPI_FUNC(PyObject *) PyImport_ImportModuleNoBlock(
+Py_DEPRECATED(3.13) PyAPI_FUNC(PyObject *) PyImport_ImportModuleNoBlock(
     const char *name            /* UTF-8 encoded string */
     );
 PyAPI_FUNC(PyObject *) PyImport_ImportModuleLevel(
diff --git a/Misc/NEWS.d/next/C API/2023-06-06-17-43-28.gh-issue-105396.FQJG5B.rst b/Misc/NEWS.d/next/C API/2023-06-06-17-43-28.gh-issue-105396.FQJG5B.rst
@@ -0,0 +1,3 @@
+Deprecate the :c:func:`PyImport_ImportModuleNoBlock` function which is just
+an alias to :c:func:`PyImport_ImportModule` since Python 3.3. Patch by
+Victor Stinner.
diff --git a/Python/import.c b/Python/import.c
@@ -2439,6 +2439,12 @@ PyImport_ImportModule(const char *name)
 PyObject *
 PyImport_ImportModuleNoBlock(const char *name)
 {
+    if (PyErr_WarnEx(PyExc_DeprecationWarning,
+        "PyImport_ImportModuleNoBlock() is deprecated and scheduled for "
+        "removal in Python 3.15. Use PyImport_ImportModule() instead.", 1))
+    {
+        return NULL;
+    }
     return PyImport_ImportModule(name);
 }
 

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	+Deprecate the :c:func:`PyImport_ImportModuleNoBlock` function which is just
	`2`	+an alias to :c:func:`PyImport_ImportModule` since Python 3.3. Patch by
	`3`	`+Victor Stinner.`
Original file line number	Diff line number	Diff line change
`@@ -2439,6 +2439,12 @@ PyImport_ImportModule(const char *name)`
`2439`	`2439`	`PyObject *`
`2440`	`2440`	`PyImport_ImportModuleNoBlock(const char *name)`
`2441`	`2441`	`{`
	`2442`	`+ if (PyErr_WarnEx(PyExc_DeprecationWarning,`
	`2443`	`+ "PyImport_ImportModuleNoBlock() is deprecated and scheduled for "`
	`2444`	`+ "removal in Python 3.15. Use PyImport_ImportModule() instead.", 1))`
	`2445`	`+ {`
	`2446`	`+ return NULL;`
	`2447`	`+ }`
`2442`	`2448`	`return PyImport_ImportModule(name);`
`2443`	`2449`	`}`
`2444`	`2450`