bpo-41056: Use the fildes converter for fd to please Coverity. (GH-21011)

gpshead · web-flow · commit 3ccb96c97824 · 2020-06-20T15:06:48.000-07:00
There are a bunch of other fd: int uses in this file, I expect many if not
all of them would be better off using the fildes converter.  This particular
one was flagged by Coverity as it presumably flags fpathconf as not accepting
negative fds.  I'd expect the other fd's to have been flagged as well
otherwise.

I'm marking this one as skip news as it really is a no-op.
diff --git a/Misc/NEWS.d/next/Library/2020-06-20-18-37-29.bpo-41056.d9v_uL.rst b/Misc/NEWS.d/next/Library/2020-06-20-18-37-29.bpo-41056.d9v_uL.rst
@@ -0,0 +1 @@
+Invalid file descriptor values are now prevented from being passed to os.fpathconf. (discovered by Coverity)
diff --git a/Modules/clinic/posixmodule.c.h b/Modules/clinic/posixmodule.c.h
diff --git a/Modules/posixmodule.c b/Modules/posixmodule.c
@@ -10988,7 +10988,7 @@ conv_path_confname(PyObject *arg, int *valuep)
 /*[clinic input]
 os.fpathconf -> long
 
-    fd: int
+    fd: fildes
     name: path_confname
     /
 
@@ -10999,7 +10999,7 @@ If there is no limit, return -1.
 
 static long
 os_fpathconf_impl(PyObject *module, int fd, int name)
-/*[clinic end generated code: output=d5b7042425fc3e21 input=5942a024d3777810]*/
+/*[clinic end generated code: output=d5b7042425fc3e21 input=5b8d2471cfaae186]*/
 {
     long limit;
 

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+Invalid file descriptor values are now prevented from being passed to os.fpathconf. (discovered by Coverity)`
Original file line number	Diff line number	Diff line change
`@@ -10988,7 +10988,7 @@ conv_path_confname(PyObject arg, int valuep)`
`10988`	`10988`	`/*[clinic input]`
`10989`	`10989`	`os.fpathconf -> long`
`10990`	`10990`
`10991`		`- fd: int`
	`10991`	`+ fd: fildes`
`10992`	`10992`	`name: path_confname`
`10993`	`10993`	`/`
`10994`	`10994`
`@@ -10999,7 +10999,7 @@ If there is no limit, return -1.`
`10999`	`10999`
`11000`	`11000`	`static long`
`11001`	`11001`	`os_fpathconf_impl(PyObject *module, int fd, int name)`
`11002`		`-/[clinic end generated code: output=d5b7042425fc3e21 input=5942a024d3777810]/`
	`11002`	`+/[clinic end generated code: output=d5b7042425fc3e21 input=5b8d2471cfaae186]/`
`11003`	`11003`	`{`
`11004`	`11004`	`long limit;`
`11005`	`11005`