Close file when error is returned

MonadChains · MonadChains · commit 25c24e4e7246 · 2022-10-28T17:35:26.000+02:00
diff --git a/Modules/_testcapimodule.c b/Modules/_testcapimodule.c
@@ -2021,6 +2021,7 @@ call_pyobject_print(PyObject *self, PyObject * args)
     }
 
     if (PyObject_Print(object, fp, flags) < 0) {
+        fclose(fp);
         return NULL;
     }
 
@@ -2042,6 +2043,7 @@ pyobject_print_null(PyObject *self, PyObject *args)
     fp = _Py_fopen_obj(filename, "w+");
 
     if (PyObject_Print(NULL, fp, 0) < 0) {
+        fclose(fp);
         return NULL;
     }
 
@@ -2071,6 +2073,7 @@ pyobject_print_noref_object(PyObject *self, PyObject *args)
     fp = _Py_fopen_obj(filename, "w+");
 
     if (PyObject_Print(test_string, fp, 0) < 0){
+        fclose(fp);
         return NULL;
     }
 
@@ -2096,6 +2099,7 @@ pyobject_print_os_error(PyObject *self, PyObject *args)
     fp = _Py_fopen_obj(filename, "r");
 
     if (PyObject_Print(test_string, fp, 0) < 0) {
+        fclose(fp);
         return NULL;
     }
 

Original file line number	Diff line number	Diff line change
`@@ -2021,6 +2021,7 @@ call_pyobject_print(PyObject self, PyObject args)`
`2021`	`2021`	`}`
`2022`	`2022`
`2023`	`2023`	`if (PyObject_Print(object, fp, flags) < 0) {`
	`2024`	`+ fclose(fp);`
`2024`	`2025`	`return NULL;`
`2025`	`2026`	`}`
`2026`	`2027`
`@@ -2042,6 +2043,7 @@ pyobject_print_null(PyObject self, PyObject args)`
`2042`	`2043`	`fp = _Py_fopen_obj(filename, "w+");`
`2043`	`2044`
`2044`	`2045`	`if (PyObject_Print(NULL, fp, 0) < 0) {`
	`2046`	`+ fclose(fp);`
`2045`	`2047`	`return NULL;`
`2046`	`2048`	`}`
`2047`	`2049`
`@@ -2071,6 +2073,7 @@ pyobject_print_noref_object(PyObject self, PyObject args)`
`2071`	`2073`	`fp = _Py_fopen_obj(filename, "w+");`
`2072`	`2074`
`2073`	`2075`	`if (PyObject_Print(test_string, fp, 0) < 0){`
	`2076`	`+ fclose(fp);`
`2074`	`2077`	`return NULL;`
`2075`	`2078`	`}`
`2076`	`2079`
`@@ -2096,6 +2099,7 @@ pyobject_print_os_error(PyObject self, PyObject args)`
`2096`	`2099`	`fp = _Py_fopen_obj(filename, "r");`
`2097`	`2100`
`2098`	`2101`	`if (PyObject_Print(test_string, fp, 0) < 0) {`
	`2102`	`+ fclose(fp);`
`2099`	`2103`	`return NULL;`
`2100`	`2104`	`}`
`2101`	`2105`