Fix incorrect error handling in _pickle.Unpickler.__init__() (GH-9630)

miss-islington · ZackerySpytz · web-flow · commit 207bb5fda52c · 2018-09-28T23:12:35.000-07:00
_pickle.Unpickler.__init__() should return -1 if Pdata_New() fails, not 1. (cherry picked from commit 4b430e5) Co-authored-by: Zackery Spytz <zspytz@gmail.com>
diff --git a/Modules/_pickle.c b/Modules/_pickle.c
@@ -6713,7 +6713,7 @@ _pickle_Unpickler___init___impl(UnpicklerObject *self, PyObject *file,
 
     self->stack = (Pdata *)Pdata_New();
     if (self->stack == NULL)
-        return 1;
+        return -1;
 
     self->memo_size = 32;
     self->memo = _Unpickler_NewMemo(self->memo_size);
