fixup! Allow repeated deletion of unittest.mock.Mock attributes

pablogsal · pablogsal · commit 0c3dde00a62a · 2018-12-10T23:09:05.000Z
diff --git a/Lib/unittest/test/testmock/testmock.py b/Lib/unittest/test/testmock/testmock.py
@@ -1790,6 +1790,14 @@ def test_mock_does_not_raise_on_repeated_attribute_deletion(self):
             self.assertRaises(AttributeError, getattr, mock, 'foo')
 
 
+    def test_mock_raises_when_deleting_inexistent_attribute(self):
+        for mock in (Mock(), MagicMock(), NonCallableMagicMock(),
+                     NonCallableMock()):
+            with self.assertRaises(AttributeError):
+                del mock.foo
+                del mock.foo
+
+
     def test_reset_mock_does_not_raise_on_attr_deletion(self):
         # bpo-31177: reset_mock should not raise AttributeError when attributes
         # were deleted in a mock instance
diff --git a/Misc/NEWS.d/next/Library/2018-12-09-21-35-49.bpo-20239.V4mWBL.rst b/Misc/NEWS.d/next/Library/2018-12-09-21-35-49.bpo-20239.V4mWBL.rst
@@ -1,2 +1,2 @@
-Allow repeated assignment deletion of ``unittest.mock.Mock`` attributes.
+Allow repeated assignment deletion of :class:`unittest.mock.Mock` attributes.
 Patch by Pablo Galindo.

Original file line number	Diff line number	Diff line change
`@@ -1,2 +1,2 @@`
`1`		-Allow repeated assignment deletion of ``unittest.mock.Mock`` attributes.
	`1`	+Allow repeated assignment deletion of :class:`unittest.mock.Mock` attributes.
`2`	`2`	`Patch by Pablo Galindo.`