cherry-pick from the newest branch#59
Merged
Merged
Conversation
ncoghlan
reviewed
Mar 23, 2017
| raise ValueError("at least one branch is required") | ||
|
|
||
| for branch in branches: | ||
| for branch in sorted(branches, reverse=True): |
Contributor
There was a problem hiding this comment.
This will already do the right thing for X.Y branches, but do we want to future-proof it against the day of 3.10 by adding key=lambda v: tuple(map(int, v.split('.')))?
ncoghlan
approved these changes
Mar 23, 2017
Write a test
Member
Author
|
Thanks :) I updated the code anyway, and added a test for it. |
brettcannon
approved these changes
Mar 23, 2017
Member
|
Maybe it's time to set up Travis if there's going to be tests? |
Member
Author
|
Sounds good :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.