-
-
Notifications
You must be signed in to change notification settings - Fork 60
Description
Re:
- https://github.com/python/cpython/blob/main/.github/workflows/stale.yml
- https://github.com/python/cpython/actions/workflows/stale.yml
The CLA [not] signed label handling has been removed because the new CLA bot doesn't use those labels, so it now won't close any stale PRs: python/cpython#91429.
What I wrote in #93 (comment) isn't accurate on two counts:
-
only-pr-labelsdoesn't restrict to processing PRs only, it overridesonly-labelsfor PRs, and for issues it will use theonly-labelsdefault instead. Anyway, it doesn't matter becauseonly-pr-labelswas deleted in the PR. -
More importantly, the action does also run for issues (for example: https://github.com/python/cpython/runs/5981894131?check_suite_focus=true) so we need to adjust the config
Aside: One option is to also mark issues as stale, but that's another conversation. We should also figure out a way to reinstate closing old PRs that don't have the CLA signed (i.e. redo #93), that's also another conversation.
I don't see any option at https://github.com/actions/stale that says "run on PRs only"? so I think what we need to do is change:
days-before-stale: 30into:
days-before-issue-stale: -1
days-before-pr-stale: 30where:
If set to a negative number like -1, no issues or pull requests will be marked as stale automatically.
In that case, you can still add the stale label manually to mark as stale.