Skip to content

Stale action should not process issues #439

@hugovk

Description

@hugovk

Re:

The CLA [not] signed label handling has been removed because the new CLA bot doesn't use those labels, so it now won't close any stale PRs: python/cpython#91429.

What I wrote in #93 (comment) isn't accurate on two counts:

  1. only-pr-labels doesn't restrict to processing PRs only, it overrides only-labels for PRs, and for issues it will use the only-labels default instead. Anyway, it doesn't matter because only-pr-labels was deleted in the PR.

  2. More importantly, the action does also run for issues (for example: https://github.com/python/cpython/runs/5981894131?check_suite_focus=true) so we need to adjust the config


Aside: One option is to also mark issues as stale, but that's another conversation. We should also figure out a way to reinstate closing old PRs that don't have the CLA signed (i.e. redo #93), that's also another conversation.


I don't see any option at https://github.com/actions/stale that says "run on PRs only"? so I think what we need to do is change:

days-before-stale: 30

into:

days-before-issue-stale: -1
days-before-pr-stale: 30

where:

If set to a negative number like -1, no issues or pull requests will be marked as stale automatically.
In that case, you can still add the stale label manually to mark as stale.

cc @erlend-aasland @ezio-melotti

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions