Skip to content

Spellcheck PRs before merge. #237

Closed as not planned
Closed as not planned

Description

@terryjreedy

In spite of previous spelling fixes over the years, there have been, I recall, at least 3 spell fix PRs over the last several months. The problem is that we keep committing patches that add new doubled words and misspellings. For #6374, Guido, who does not like the code churn, said "Ideally spell checks would run on PRs.".

I presume people preparing the patches are using some combination of of python with re and some linux facility. I have no idea how many false positives such people have to ignore.

A separate issue is whether passing a spell check should be opt in or opt out.

Activity

  1. scop commented on May 4, 2018

    @scop

    For my part, I've been using https://github.com/client9/misspell with decent results, as well as some local greps.

  2. AA-Turner commented on Aug 12, 2025

    @AA-Turner
    Member

    Closing, stale. We have adopted something along these lines, eg make codespell, but I don't want to invite lots of low-quality typo fix PRs.

    A

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions