Skip to content

Conversation

@DanielNoord
Copy link
Contributor

Closes #59.

Did this in a similar way as many other packages or doing this. If the sys guard is not desired I'll obviously remove it.

@hugovk
Copy link
Member

hugovk commented Jul 8, 2022

The sys guard is good, it'll be easy to find and remove when dropping support for 3.10 and older.

Please could you add 3.11-dev to .github/workflows/main.yml so we test on the 3.11 pre-release as well?

@DanielNoord
Copy link
Contributor Author

DanielNoord commented Jul 8, 2022

The sys guard is good, it'll be easy to find and remove when dropping support for 3.10 and older.

Please could you add 3.11-dev to .github/workflows/main.yml so we test on the 3.11 pre-release as well?

Do you want me to also add the 3.11 PyPI classifier? Or is that something that should be added after 3.11 is released?

Edit: I just saw only the 3.7 classifier has been added. If you want the 3.11 one I'll also add the others.

@hugovk
Copy link
Member

hugovk commented Jul 8, 2022

Personally I would add 3.11 (this is a pure Python package so it should be fine, if not, we'd better fix it!) and the other versions.

I also add:

Programming Language :: Python :: 3
Programming Language :: Python :: 3 :: Only

But some projects prefer to keep a minimal list. Maybe add them and we can always remove if the maintainers prefer?

@DanielNoord
Copy link
Contributor Author

The 3.11 tests fail. Should I move those to another PR and fix the issues there?

@hugovk
Copy link
Member

hugovk commented Jul 8, 2022

Ah right, I think that can be another PR/issue 👍

We'll probably need something like these env vars for temporary workarounds:

https://github.com/python/bedevere/blob/6aebdb401e51d167d3f544e9f00105dcf8c16eed/tox.ini#L9-L15

@DanielNoord
Copy link
Contributor Author

I'll wait on #68 then.

Can we merge this without the test on 3.11 or should that be blocked by it?

@hugovk
Copy link
Member

hugovk commented Jul 9, 2022

It would be nice to test on 3.11, but we're not quite there yet (see #68 (comment)) and this PR looks safe enough, so maybe just back out the .github/workflows/main.yml change and we're good to merge this?

@ezio-melotti ezio-melotti merged commit ad3433c into python:main Jul 14, 2022
@DanielNoord DanielNoord deleted the toml branch July 14, 2022 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Consider switching from toml to tomli

3 participants