Skip to content

Add FedoraBuild for Fedora and RHEL#264

Merged
vstinner merged 4 commits intopython:mainfrom
vstinner:fedora
Sep 9, 2021
Merged

Add FedoraBuild for Fedora and RHEL#264
vstinner merged 4 commits intopython:mainfrom
vstinner:fedora

Conversation

@vstinner
Copy link
Copy Markdown
Member

@vstinner vstinner commented Sep 9, 2021

Test ./configure --with-platlibdir=lib64 on Fedora and RHEL, but also
other configure flags used by the Fedora specfile, like
--enable-shared and --with-system-expat.

@vstinner
Copy link
Copy Markdown
Member Author

vstinner commented Sep 9, 2021

Build / build (pull_request) Failing after 14s — build

"make" when installing Tempita in a venv:

error in Tempita setup command: use_2to3 is invalid.

See https://twitter.com/mitsuhiko/status/1435661088746577930

"Latest setuptools removes the ability to invoke 2to3 as part of the installation. With that Flask-OpenID broke which means that Airflow broke. I don't even have the energy to fix an ancient package at this point but apparently existing airflow installations are now screwed :-/"

flask-openid fix to avoid 2to3: pallets-eco/flask-openid#60

@vstinner
Copy link
Copy Markdown
Member Author

vstinner commented Sep 9, 2021

For Tempita use_2to3 error, see: https://bugs.launchpad.net/sqlalchemy-migrate/+bug/1943127

@vstinner
Copy link
Copy Markdown
Member Author

vstinner commented Sep 9, 2021

I also reported the issue to buildbot: buildbot/buildbot#6229

@vstinner
Add FedoraBuild for Fedora and RHEL
fd065bd 
Test ./configure --with-platlibdir=lib64 on Fedora and RHEL, but also
other configure flags used by the Fedora specfile, like
--enable-shared and --with-system-expat.
@vstinner
Copy link
Copy Markdown
Member Author

vstinner commented Sep 9, 2021

error in Tempita setup command: use_2to3 is invalid.

I pushed a workaround: 73a70b5

hroncok
hroncok reviewed Sep 9, 2021
View reviewed changes
master/custom/factories.py Outdated
"--with-dbmliborder=gdbm:ndbm:bdb",
"--with-system-expat",
"--with-system-ffi",
"--with-system-libmpdec",
Copy link
Copy Markdown

@hroncok hroncok Sep 9, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding options like this means we need to pull in the devel packages. Also, IIRC we can only use system mpdec in 3.10+

Copy link
Copy Markdown
Contributor

@stratakis stratakis Sep 9, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The devel packages are already in the buildbots

hroncok
hroncok reviewed Sep 9, 2021
View reviewed changes
master/custom/factories.py
# https://src.fedoraproject.org/rpms/python3.10/blob/rawhide/f/python3.10.spec
configureFlags = [
"--with-pydebug",
"--with-platlibdir=lib64",
Copy link
Copy Markdown

@hroncok hroncok Sep 9, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This only makes sense on 64bit arches.

Copy link
Copy Markdown
Contributor

@stratakis stratakis Sep 9, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the Fedora and RHEL buildbots are 64 bits.

@vstinner vstinner merged commit 0df201d into python:main Sep 9, 2021
@vstinner vstinner deleted the fedora branch September 9, 2021 16:33
@vstinner
Copy link
Copy Markdown
Member Author

vstinner commented Sep 9, 2021

@hroncok @stratakis: I prefer to start easy, I disabled --with-system-expat, --with-system-ffi and --with-system-libmpdec. Let's see first how many buildbot workers are broken by this first incomplete change :-D

Also, I created one configuration per OS version:

  • Fedora Stable
  • Fedora Rawhide
  • RHEL7
  • RHEL8

For now, RHEL7 and RHEL8 are the same, so are Fedora Stable and Fedora Rawhide.

@vstinner
Copy link
Copy Markdown
Member Author

vstinner commented Sep 9, 2021

s390x RHEL8 3.10: configure failed: https://buildbot.python.org/all/#/builders/700/builds/341

checking for valgrind/valgrind.h... no
configure: error: Valgrind support requested but headers not available

PPC64LE RHEL7 3.10: https://buildbot.python.org/all/#/builders/619/builds/311

(same Valgrind error)

s390x RHEL7 3.10: https://buildbot.python.org/all/#/builders/658/builds/351

(same Valgrind error)

s390x Fedora 3.10: https://buildbot.python.org/all/#/builders/655/builds/338

(same Valgrind error)

@hroncok
Copy link
Copy Markdown

hroncok commented Sep 9, 2021

That is because Valgrind has:

ExclusiveArch: %{ix86} x86_64 ppc ppc64 ppc64le s390x armv7hl aarch64

https://src.fedoraproject.org/rpms/valgrind/blob/rawhide/f/valgrind.spec#_230

Fedora's Python has:

# Support for the Valgrind debugger/profiler
%ifarch %{valgrind_arches}
%bcond_without valgrind
%else
%bcond_with valgrind
%endif

@vstinner
Copy link
Copy Markdown
Member Author

vstinner commented Sep 9, 2021

I rebuilt "s390x RHEL8 3.10" without the Valgrind flag and it went a little bit further until...

checking for dtrace... not found
configure: error: dtrace command not found on $PATH

@vstinner
Copy link
Copy Markdown
Member Author

vstinner commented Sep 9, 2021

I disabled Valgrind: d05087c

And DTrace: a013e17

@vstinner vstinner mentioned this pull request Sep 9, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@hroncok hroncok hroncok left review comments

@stratakis stratakis stratakis left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vstinner @hroncok @stratakis