Skip to content

Avoid artifact upload collisions between benchmark jobs #487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
savannahostrowski wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −3
Open

Avoid artifact upload collisions between benchmark jobs #487

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions bench_runner/templates/_benchmark.src.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ jobs:
- name: Upload artifacts
uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.0
with:
name: benchmark
name: benchmark-${{ env.BENCHMARK_MACHINE_NICKNAME }}-${{ env.flags }}

@maurycy maurycy Nov 12, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what happens here, but _benchmark is called twice:

https://github.com/python/bench_runner/blob/main/bench_runner/templates/benchmark.src.yml#L75-L87

Does it mean reusing or ovewriting? I worry it's the latter

path: |
benchmark.json
overwrite: true
Expand Down Expand Up @@ -131,7 +131,7 @@ jobs:
if: ${{ !inputs.perf }}
uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.0
with:
name: benchmark
name: benchmark-${{ env.BENCHMARK_MACHINE_NICKNAME }}-${{ env.flags }}
path: |
benchmark.json
overwrite: true
Expand Down Expand Up @@ -170,7 +170,7 @@ jobs:
- name: Upload artifacts
uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.0
with:
name: benchmark
name: benchmark-${{ env.BENCHMARK_MACHINE_NICKNAME }}-${{ env.flags }}
path: |
benchmark.json
overwrite: true
Loading