Repository navigation
Add pre-commit and migrate to Ruff - #478
Open
savannahostrowski wants to merge 4 commits into
Open
savannahostrowski wants to merge 4 commits into
savannahostrowski wants to merge 4 commits into
Conversation
maurycy
approved these changes
Nov 12, 2026
| @@ -0,0 +1,18 @@ | |||
| repos: | |||
| - repo: https://github.com/astral-sh/ruff-pre-commit | |||
| rev: e05c5c0818279e5ac248ac9e954431ba58865e61 # frozen: v0.15.7 | |||
There was a problem hiding this comment.
If I understand correctly, it's pinned twice:
| run: python -m pip install .[test] | ||
| - name: Run lints | ||
| run: ./lint.sh | ||
| run: python -m pip install ".[test]" |
There was a problem hiding this comment.
pyperf does this in a separate job:
https://github.com/psf/pyperf/blob/main/.github/workflows/lint.yml#L5
What do you think about this approach?
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I figured we could start aligning with the conventions we have in CPython: replacing black + flake8 with ruff, and adding pre-commit to streamline things and catch lint failures before they hit CI.
I haven't bumped line length to 79 here (would be a fairly mechanical 30-ish file reformat) but happy to do that if we think it's worthwhile. Also haven't touched the typechecker but would be interested in opinions on whether we should migrate from pyright to mypy.