Repository navigation
Add synthesize_loops_file script - #395
Merged
Merged
Conversation
mdboom
marked this pull request as draft
April 7, 2025 13:05
benchmark results.
data points and benchmarks, and drop the mean/median options for merging results, as they've become even more nonsensical now.
Yhg1s
force-pushed
the
synthesize_loops_script
branch
from
April 7, 2025 13:20
8aed397 to
070e1ec
Compare
mdboom
marked this pull request as ready for review
April 9, 2025 21:31
mdboom
approved these changes
Apr 9, 2025
mdboom
left a comment
mdboom
left a comment
Contributor
There was a problem hiding this comment.
This looks fine, and mergeable (it's independent from everything else, anyway).
Let's together work on fixing the issues upstream in pyperformance that make these hard-coded lists necessary and then remove them when that's done.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a command to synthesize a pyperformance loops file from one or more benchmark results.