Fix assertion rewriting on Python 3.10 by hauntsaninja · Pull Request #8540 · pytest-dev/pytest

hauntsaninja · 2021-04-11T22:43:09Z

Fixes #8539

This seems to have been the result of https://bugs.python.org/issue43798

Fixes pytest-dev#8539 This seems to have been the result of https://bugs.python.org/issue43798

for more information, see https://pre-commit.ci

hauntsaninja · 2021-04-11T23:02:32Z

Hmm, looks like the test is failing on master as well. Looks like it's benjaminp/six#352

asottile · 2021-04-12T01:59:45Z

src/_pytest/assertion/rewrite.py

            return
+
        # Insert some special imports at the top of the module but after any
        # docstrings and __future__ imports.


this comment has been orphaned

That comment is still relevant in its current place! L690-L720 is figuring out the "after any docstrings and __future__ imports part".

it's 40 lines away from the code that's relevant to the comment (the "special imports")

Okay, made a change! :-)

asottile

It currently breaks all builds and even after pytest-dev#8540 it looks like tests still fail because of benjaminp/six#341 As a hotfix, mark it as experimental until everything is fixed, so that our CI isn't all red.

The-Compiler · 2021-04-14T09:29:44Z

Could someone elaborate on how I can actually reproduce this? I'm trying to fix the testsuite on Python 3.10, but I don't see this issue happening at all.

asottile · 2021-04-14T14:15:27Z

Could someone elaborate on how I can actually reproduce this? I'm trying to fix the testsuite on Python 3.10, but I don't see this issue happening at all.

for example: https://github.com/asottile/flake8-match

git clone git@github.com:asottile/flake8-match
sudo add-apt-repository ppa:deadsnakes/nightly
sudo apt install python3.10-dev
tox -e py310

The-Compiler · 2021-04-14T14:59:04Z

Ah, I see - I was running 3.10.0a7 (because that's what @Zac-HD mentioned in the issue), but this is actually a very recent change. I can reproduce it when installing python3.10-dev via pyenv, which gives me "Python 3.10.0a7+ (heads/master:d9ba9de, Apr 14 2021, 16:49:31)".

This also explains why this isn't needed on CI - it will be once beta 1 is out.

nicoddemus

Thanks a lot @hauntsaninja!

nicoddemus · 2021-04-15T11:56:07Z

Should have squashed, my bad! 🤦‍♂️

hroncok · 2021-04-15T11:59:39Z

Will this not break actual alpha 7?

nicoddemus · 2021-04-15T12:02:00Z

Hmm I suppose, good point. Should we revert this and wait for beta 1?

hroncok · 2021-04-15T12:08:45Z

I think we can make the version check more specific.

hroncok · 2021-04-15T12:14:03Z

I cannot trigger a problem on Python 3.10.0a7, so maybe this is fine.

The-Compiler · 2021-04-19T09:42:39Z

FYI, GitHub Actions seems to have pushed a rather weird "beta 1" release which isn't actually beta 1 - so if we're seeing an influx of new reports about this, that'd be why (as python: 3.10-dev now uses that affected release rather than Alpha 7).

Referencias: - actions/setup-python#207 - pytest-dev/pytest#8540 (comment) This reverts commit 05e8867.

alirezatheh · 2022-05-30T13:40:39Z

I'm still having this issue on Python 3.10.4, pytest 7.1.2!

asottile · 2022-05-30T14:27:07Z

@alirezatheh please open a new issue with a reproduction

Required upgrade to 6.25 to fix assertion error running coverage. See: pytest-dev/pytest#8540

parsanoori · 2022-07-23T06:57:10Z

Still have this problem:

git clone https://gitlab.com/nanuchi/gitlab-cicd-crash-course.git
cd gitlab-cicd-crash-course
make test

The output is:

. src/.venv/bin/activate \
&& pytest -v
========================================================= test session starts =========================================================
platform linux -- Python 3.10.4, pytest-6.2.2, py-1.11.0, pluggy-0.13.1 -- /home/parsa/gits/gitlab-cicd-crash-course/src/.venv/bin/python3
cachedir: .pytest_cache
rootdir: /home/parsa/gits/gitlab-cicd-crash-course
collected 0 items / 1 error                                                                                                           

=============================================================== ERRORS ================================================================
____________________________________________________ ERROR collecting test session ____________________________________________________
/usr/lib/python3.10/importlib/__init__.py:126: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
<frozen importlib._bootstrap>:1050: in _gcd_import
    ???
<frozen importlib._bootstrap>:1027: in _find_and_load
    ???
<frozen importlib._bootstrap>:1006: in _find_and_load_unlocked
    ???
<frozen importlib._bootstrap>:688: in _load_unlocked
    ???
src/.venv/lib/python3.10/site-packages/_pytest/assertion/rewrite.py:161: in exec_module
    source_stat, co = _rewrite_test(fn, self.config)
src/.venv/lib/python3.10/site-packages/_pytest/assertion/rewrite.py:356: in _rewrite_test
    co = compile(tree, fn_, "exec", dont_inherit=True)
E   TypeError: required field "lineno" missing from alias
======================================================= short test summary info =======================================================
ERROR  - TypeError: required field "lineno" missing from alias
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! Interrupted: 1 error during collection !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
========================================================== 1 error in 0.23s ===========================================================
make: *** [makefile:56: test] Error 2

Related info:

python3 --version # the command
Python 3.10.4 # the output


python3 -m pytest --version # the command
pytest 7.1.2 # the output

The-Compiler · 2022-07-23T07:36:28Z

@parsanoori as seen in the output header, you're actually running pytest 6.2.2 in the virtualenv there.

parsanoori · 2022-07-23T09:17:32Z

It's the git maintainer's problem.
Thanks.

`poetry update pytest` to get pytest-dev/pytest#8540 for Python 3.10 compatibility

Resolves assertion rewriting issue when running in Python 3.10. See pytest-dev/pytest#8540

- Bump pytest from 5.3.4 to 7.2.0 The old version of pytest did not support python3.10 Rel: pytest-dev/pytest#8540

- Bump pytest from 5.3.4 to 7.2.0 - Bump pytest-bdd from 3.2.1 6.1.1 The old version of pytest/pytest-bdd did not support python3.10 Rel: pytest-dev/pytest#8540

- Bump pytest from 5.3.4 to 7.2.0 - Bump pytest-bdd from 3.2.1 4.1.0 The old version of pytest/pytest-bdd did not support python3.10 Rel: pytest-dev/pytest#8540

Bump pytest and pytes-bdd to get support for python3.10 - pytest from 5.3.4 to 7.2.0 - pytest-bdd from 3.2.1 to 4.1.0 (5 and 6 have to many breaking changes) See: https://github.com/pytest-dev/pytest-bdd/blob/master/CHANGES.rst Bump other dependencies - boto3 - bravado-core - cryptography - pycodestyle - PyJWT - pytest-parallel - requests The `requirements.txt` was updated wit the output from `pip freeze` after new version of the dependencies was installed Rel: pytest-dev/pytest#8540

Python 3.10 broke pytest <6.2.4: pytest-dev/pytest#8539 (comment) Fix implemented pytest-dev/pytest#8540

Increased the version of pytest to make it work with py 3.10 [0]. The GET calls no longer return list but the object itself, fixed the tests and assertions to account for that. The tests did not account for the later added `allow_user_remove_domain` setting. And there were issues with missing and non-stopped patchers/mocks. Now all tests are at least passing. [0] pytest-dev/pytest#8540

hauntsaninja and others added 2 commits April 11, 2021 15:42

Fix assertion rewriting on Python 3.10

8be1628

Fixes pytest-dev#8539 This seems to have been the result of https://bugs.python.org/issue43798

[pre-commit.ci] auto fixes from pre-commit.com hooks

da66f00

for more information, see https://pre-commit.ci

asottile reviewed Apr 12, 2021

View reviewed changes

fixup comments

e3dc34e

asottile approved these changes Apr 12, 2021

View reviewed changes

The-Compiler mentioned this pull request Apr 14, 2021

ci: Mark Python 3.10 as experimental #8553

Closed

The-Compiler mentioned this pull request Apr 14, 2021

Fix Python 3.10 test issues #8555

Merged

The-Compiler mentioned this pull request Apr 15, 2021

Test failures with Python 3.10.0a7 #8546

Closed

nicoddemus approved these changes Apr 15, 2021

View reviewed changes

nicoddemus merged commit af31c60 into pytest-dev:main Apr 15, 2021

Kriechi mentioned this pull request Apr 15, 2021

Fix repr() checks for Python 3.10 python-hyper/h2#1254

Closed

The-Compiler mentioned this pull request Apr 19, 2021

Assertion rewriting fails under Python 3.10.0a7+ #8539

Closed

hugovk mentioned this pull request Apr 19, 2021

Remove generated translation binaries from repo jmoiron/humanize#199

Merged

pquentin mentioned this pull request Apr 20, 2021

Fix Python 3.10 tests urllib3/urllib3#2201

Merged

LeMyst mentioned this pull request Apr 21, 2021

Change and remove FunctionsEngine functions LeMyst/WikibaseIntegrator#129

Merged

Molkree mentioned this pull request Apr 23, 2021

Test with Python 3.9 - look for deprecation ossf/cve-bin-tool#910

Closed

williamjmorenor added a commit to cacao-accounting/cacao-accounting that referenced this pull request Apr 23, 2021

Revert "ci: Actualiza version de python 3.10"

fd8482d

Referencias: - actions/setup-python#207 - pytest-dev/pytest#8540 (comment) This reverts commit 05e8867.

hauntsaninja deleted the assert310 branch April 27, 2021 18:24

asottile mentioned this pull request May 4, 2021

[6.2.x] Merge pull request #8540 from hauntsaninja/assert310 #8629

Merged

linville mentioned this pull request Apr 8, 2022

Inspect object has no attribute date_format atac/c10-tools#19

Closed

kuwv mentioned this pull request Apr 16, 2022

pytest 6 support bitprophet/pytest-relaxed#12

Open

svlandeg mentioned this pull request Apr 21, 2022

👷 Add CI for Python 3.10 fastapi/typer#384

Merged

tirkarthi mentioned this pull request Apr 26, 2022

[BUG] pytests incompatible with python 3.10 distributed-system-analysis/pbench#2778

Open

1 task

rtibbles mentioned this pull request May 2, 2022

Python 3.10 support learningequality/kolibri#9393

Merged

9 tasks

corubba mentioned this pull request May 18, 2022

Fix tests PowerDNS-Admin/PowerDNS-Admin#1198

Closed

michaelkuhn mentioned this pull request Jun 4, 2022

Cannot run unit tests with Python 3.10 spack/spack#30991

Closed

3 tasks

kevinbowen777 added a commit to kevinbowen777/cheese that referenced this pull request Jun 10, 2022

Update pytest to fix assertion rewriting

829e724

Required upgrade to 6.25 to fix assertion error running coverage. See: pytest-dev/pytest#8540

foster999 mentioned this pull request Jun 25, 2022

👌 IMPROVE: Add support and testing for sphinx 5 executablebooks/sphinx-tabs#164

Merged

AetherUnbound mentioned this pull request Jul 7, 2022

Bump python from 3.9-slim->3.10.5-slim, pytest 5.2.2->7.1.2 OrcaCollective/OpenOversight#154

Merged

abesto added a commit to abesto/ghstack that referenced this pull request Aug 9, 2022

Bump pytest 6.2.2 -> 6.2.5

d021439

`poetry update pytest` to get pytest-dev/pytest#8540 for Python 3.10 compatibility

abesto mentioned this pull request Aug 9, 2022

Bump pytest 6.2.2 -> 6.2.5 ezyang/ghstack#110

Merged

ezyang pushed a commit to ezyang/ghstack that referenced this pull request Aug 9, 2022

Bump pytest 6.2.2 -> 6.2.5 (#110)

7103cfb

`poetry update pytest` to get pytest-dev/pytest#8540 for Python 3.10 compatibility

gsweene2 mentioned this pull request Aug 27, 2022

Use DI & Upgrade Pytest gsweene2/python-poetry-template#4

Merged

akhildevelops mentioned this pull request Aug 30, 2022

Upgrade Pytest version to 7.1 python-poetry/poetry#6266

Closed

3 tasks

sbelluzzo added a commit to sbelluzzo/pipelinewise-target-postgres that referenced this pull request Sep 16, 2022

Bump pytest dev dependency to 6.2.5

b19885c

Resolves assertion rewriting issue when running in Python 3.10. See pytest-dev/pytest#8540

frodeaa pushed a commit to Dintero/docker-pytest-bdd that referenced this pull request Nov 19, 2022

Bump python from 3.8 to 3.10

744c0d4

- Bump pytest from 5.3.4 to 7.2.0 The old version of pytest did not support python3.10 Rel: pytest-dev/pytest#8540

frodeaa mentioned this pull request Nov 19, 2022

Bump python from 3.8 to 3.10 Dintero/docker-pytest-bdd#4

Merged

tenzen-y mentioned this pull request Dec 11, 2022

Upgrade Python version to 3.10 kubeflow/katib#2057

Merged

1 task

Jacob-Stevens-Haas added a commit to dynamicslab/pysindy that referenced this pull request Apr 7, 2023

BUG: Bump pytest version in dev

467223c

Python 3.10 broke pytest <6.2.4: pytest-dev/pytest#8539 (comment) Fix implemented pytest-dev/pytest#8540

jpcurbelo pushed a commit to jpcurbelo/pysindy_fork that referenced this pull request Apr 30, 2024

BUG: Bump pytest version in dev

c9e62e5

Python 3.10 broke pytest <6.2.4: pytest-dev/pytest#8539 (comment) Fix implemented pytest-dev/pytest#8540

Uh oh!

Conversation

hauntsaninja commented Apr 11, 2021

Uh oh!

hauntsaninja commented Apr 11, 2021

Uh oh!

asottile Apr 12, 2021

Choose a reason for hiding this comment

Uh oh!

hauntsaninja Apr 12, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

asottile Apr 12, 2021

Choose a reason for hiding this comment

Uh oh!

hauntsaninja Apr 12, 2021

Choose a reason for hiding this comment

Uh oh!

asottile left a comment

Choose a reason for hiding this comment

Uh oh!

The-Compiler commented Apr 14, 2021

Uh oh!

asottile commented Apr 14, 2021

Uh oh!

The-Compiler commented Apr 14, 2021

Uh oh!

nicoddemus left a comment

Choose a reason for hiding this comment

Uh oh!

nicoddemus commented Apr 15, 2021

Uh oh!

hroncok commented Apr 15, 2021

Uh oh!

nicoddemus commented Apr 15, 2021

Uh oh!

hroncok commented Apr 15, 2021

Uh oh!

hroncok commented Apr 15, 2021

Uh oh!

The-Compiler commented Apr 19, 2021

Uh oh!

alirezatheh commented May 30, 2022

Uh oh!

asottile commented May 30, 2022

Uh oh!

parsanoori commented Jul 23, 2022

Uh oh!

The-Compiler commented Jul 23, 2022

Uh oh!

parsanoori commented Jul 23, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

hauntsaninja Apr 12, 2021 •

edited

Loading