PyEditor changes / improvements#2472
Open
WebReflection wants to merge 13 commits into
Open
Conversation
7dbe77f to
bb94d11
Compare
f17ff6c to
8d24a7b
Compare
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This MR provides new features and changes (for good) some other.
Changes
rowsattributeenv-overrideattribute within the scriptonbeforerunattribute that should contain Python code as one-liner string.outputcan now be specified as id of the target output so that the editor will not create its own containerNotes
All these features have been visually and practically tested live (by me and others) but most of these require convoluted orchestration that is neither easy to provide as mock/test nor easy to ensure visually, due CSS and different heights / buttons playing their role.
This is also likely part of an even bigger refactoring/upgrade of the editor potentials but I feel like the current milestone is good enough to help our users further too.
This MR would also allow us to release PyScript with all the latest available runtime and features/dependencies.
Checklist
make buildworks locally.