Rename offline zip #2413
Merged
Rename offline zip #2413
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
| </body> | ||
| </html></pre> | ||
| </html></pre | ||
| > |
Contributor
There was a problem hiding this comment.
what is this? ... I'd add a \n before the ending </pre>
Member
Author
There was a problem hiding this comment.
This is pre-commit hook messing with HTML. :-/ Will look into this.
| <a href="offline__VERSION_.zip">offline__VERSION_.zip</a> (PyScript _VERSION_ | ||
| zipped up for offline use) | ||
| <a href="offline__VERSION_.zip">offline__VERSION_.zip</a> | ||
| (PyScript _VERSION_ zipped up for offline use) |
Contributor
There was a problem hiding this comment.
this looks fine, it will result into just a space once visualized
Member
Author
There was a problem hiding this comment.
Yeah, again pre-commit hook mangled this. 🤦
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This addresses #2346 discussions about including PyScript version information. To this end the
offline.zipfile is renamed tooffline_<CALVER>.zip(e.g.offline_2025.11.3.zip) so it's easy to identify which version of PyScript is contained within the archive.Changes
sedcommand so replacement is global within a line (thegflag).Checklist
make buildworks locally.