Skip to content

Conversation

@WebReflection
Copy link
Contributor

@WebReflection WebReflection commented Nov 19, 2025

Description

This MR fixes #2404 by avoiding trying to set a type field to the config if such config was not available as object because there is only a single URL to point at when a PyWorker is bootstrapped.

This basically invalidated the assumption it was Polyscript fault being unable to understand configs, it was actually our stdlib initialization.

Changes

  • avoided type assignment for an otherwise empty config within the worker which defaults to the used string out of the DOM declaration
  • added a test that verifies everything works as expected

Checklist

  • I have checked make build works locally.
  • I have created / updated documentation for this change (if applicable).

@WebReflection WebReflection requested a review from ntoll November 19, 2025 10:32
Copy link
Member

@ntoll ntoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@WebReflection WebReflection merged commit 7afe5c5 into pyscript:main Nov 25, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PyWorker config resolution for strings

2 participants