Fix #2404 - avoid throwing on string config #2405
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This MR fixes #2404 by avoiding trying to set a
typefield to theconfigif such config was not available as object because there is only a single URL to point at when a PyWorker is bootstrapped.This basically invalidated the assumption it was Polyscript fault being unable to understand configs, it was actually our
stdlibinitialization.Changes
typeassignment for an otherwise empty config within the worker which defaults to the used string out of the DOM declarationChecklist
make buildworks locally.