pre-commit: Upgrade the Python linter ruff #2370
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WebReflection
approved these changes
Aug 18, 2025
Contributor
WebReflection
left a comment
WebReflection
left a comment
There was a problem hiding this comment.
to whom it might concern, and for history sake, we have branches around different runtimes so that such "unreasonable" rule is unreasonable to us because we cannot import non existent modules, or modules that are different, in MicroPython and/or Pyodide and vice-versa, since our goal is to try to simplify divergent logic and converge as much as we can.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes:
Upgrade the Python linter
ruffin pre-commit by:ruff rule PLC0415discussed at https://docs.astral.sh/ruff/rules/import-outside-top-levelruff rule E402discussed at https://docs.astral.sh/ruff/rules/module-import-not-at-top-of-fileruff rule F811discussed at https://docs.astral.sh/ruff/rules/redefined-while-unusedChanges
Fix three redefinitions (the last defined persists in Python).
Checklist
make buildworks locally.