Skip to content

Conversation

@pre-commit-ci
Copy link
Contributor

@pre-commit-ci pre-commit-ci bot commented Jun 2, 2025

@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch from 602e279 to 3abc243 Compare July 7, 2025 18:56
@WebReflection
Copy link
Contributor

ruff is asking things that don't make any sense in this project, like import statements always on top of the file, when we clearly need to branch out MicroPython from Pyodide capabilities, as example + lazy modules on demand ... what should we do? /cc @ntoll

@ntoll
Copy link
Member

ntoll commented Jul 24, 2025

I have very mixed feelings about such linters. Often they're trying to be helpful but in reality just cause unnecessary overhead. Furthermore, creating bespoke overrides for project-specific behaviour is a black art, usually done once and then forgotten and when broken causes yet more maintenance overhead.

@WebReflection
Copy link
Contributor

WebReflection commented Jul 24, 2025

What you said + the fact I am actually in favor of linters as long as their rules are accepted by the team ... this automation imposes new rules out of context so, like you said, it's likely just maintenance burden that easily drops focus on what matters: our tests coverage and features for both runtimes.

Accordingly, I'm not sure we should disable it or just keep overriding its rules on every new update but either works, right now we cannot just merge (at all) this automated PR.

updates:
- [github.com/astral-sh/ruff-pre-commit: v0.11.8 → v0.12.7](astral-sh/ruff-pre-commit@v0.11.8...v0.12.7)
@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch from 5c20112 to b089123 Compare August 4, 2025 19:05
@cclauss
Copy link
Contributor

cclauss commented Aug 9, 2025

I have created a separate pull request to help us move forward. Different sets of rules make sense for different projects. I have turned off (ignored) ruff rule PLC0415 in multiple projects and believe it should also be turned off here.

This project is awesome so I am delighted to contribute where I can. Ruff is still not v1 (common for Rust and Go tools) so rules can still be added from upstream linters. if you @mention me on broken PRs, I will gladly help to get things unstuck.

@WebReflection
Copy link
Contributor

@cclauss there are no changes right now in here ... shall we close this?

@cclauss
Copy link
Contributor

cclauss commented Aug 18, 2025

pre-commit run

I believe that there is a newer version of ruff.

@cclauss
Copy link
Contributor

cclauss commented Aug 18, 2025

https://github.com/astral-sh/ruff/releases --> v0.12.9

This can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants