-
Notifications
You must be signed in to change notification settings - Fork 1.5k
[pre-commit.ci] pre-commit autoupdate #2350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
602e279 to
3abc243
Compare
|
|
|
I have very mixed feelings about such linters. Often they're trying to be helpful but in reality just cause unnecessary overhead. Furthermore, creating bespoke overrides for project-specific behaviour is a black art, usually done once and then forgotten and when broken causes yet more maintenance overhead. |
|
What you said + the fact I am actually in favor of linters as long as their rules are accepted by the team ... this automation imposes new rules out of context so, like you said, it's likely just maintenance burden that easily drops focus on what matters: our tests coverage and features for both runtimes. Accordingly, I'm not sure we should disable it or just keep overriding its rules on every new update but either works, right now we cannot just merge (at all) this automated PR. |
updates: - [github.com/astral-sh/ruff-pre-commit: v0.11.8 → v0.12.7](astral-sh/ruff-pre-commit@v0.11.8...v0.12.7)
5c20112 to
b089123
Compare
|
I have created a separate pull request to help us move forward. Different sets of rules make sense for different projects. I have turned off (ignored) ruff rule PLC0415 in multiple projects and believe it should also be turned off here. This project is awesome so I am delighted to contribute where I can. Ruff is still not v1 (common for Rust and Go tools) so rules can still be added from upstream linters. if you @mention me on broken PRs, I will gladly help to get things unstuck. |
|
@cclauss there are no changes right now in here ... shall we close this? |
|
pre-commit run I believe that there is a newer version of |
|
https://github.com/astral-sh/ruff/releases --> v0.12.9 This can be closed. |
updates: