This repository was archived by the owner on Dec 23, 2024. It is now read-only.
Add get_chat_onlines method#654
Merged
Merged
Conversation
alissonlauffer
suggested changes
Apr 4, 2021
| async def get_chat_onlines( | ||
| self, | ||
| chat_id: Union[int, str] | ||
| ) -> Optional[int]: |
Contributor
There was a problem hiding this comment.
The function does not return None. Just int or raise an exception.
Suggested change
| ) -> Optional[int]: | |
| ) -> int: |
| # You should have received a copy of the GNU Lesser General Public License | ||
| # along with Pyrogram. If not, see <http://www.gnu.org/licenses/>. | ||
|
|
||
| from typing import Optional, Union |
Contributor
There was a problem hiding this comment.
Unused import when applying the suggestion below.
Suggested change
| from typing import Optional, Union | |
| from typing import Union |
delivrance
suggested changes
May 11, 2021
delivrance
left a comment
delivrance
left a comment
Member
There was a problem hiding this comment.
get_chat_online_count sounds better to me.
delivrance
added a commit
that referenced
this pull request
May 12, 2021
commit d6dcf98d7445cbdc2a036deca57207c14bc354fc
Author: Dan <14043624+delivrance@users.noreply.github.com>
Date: Wed May 12 09:35:18 2021 +0200
Rename get_chat_onlines to get_chat_online_count
commit 21ff2a39d856ebc939ce9b15810198c82a9c23c6
Merge: 808c629 29701a3
Author: Dan <14043624+delivrance@users.noreply.github.com>
Date: Wed May 12 09:32:59 2021 +0200
Merge branch 'master' into get-chat-online-count
commit 808c629
Author: Andriel Rodrigues <andrielkogama2@gmail.com>
Date: Wed May 12 04:28:53 2021 -0300
Add get_chat_online_count method (todo) (#654)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Used to get the number of online users in a specific group.