Revert matrix auth #187
Merged
Revert matrix auth #187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commits 29c1803 c79dd18 568f901 and 3d37c00. This has resulted in bugs referenced in pypiserver#175, pypiserver#179, and pypiserver#186.
In addition to including tests from @jameshiebert with slight updates, I have also resolved an issue with newer versions of twine, which require an extra parameter in the calls to `upload` and `register`.
Member
|
@mplanchard you seem to know your way around this patch much more that me - given tha fact that i had barely seen the new functionality when was submitted originally. Looking once more to the deleted code i beleiev we took the correct decision - hand-parsing cmdline arguments is a nest of problems further down the road. Please go ahead and merge it. |
ankostis
approved these changes
Nov 14, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts the Matrix auth feature in #132, due to discovered bugs in the 1.2.1dev0 pre-release, described in #186, #175, and #179.
I have also updated a test that necessitated a version pin on twine for the dev environment, due to an additional positional argument being added to a twine command in pypa/twine#203.
Special thanks go out to @jameshiebert for the POC tests that have been more or less directly ported into this PR.