Do not use broken dependencies #254
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Requests v2.15.x was released and found to be awfully broken. Requests v2.16.x was released and is horribly backwards incompatible. See also https://github.com/kennethreitz/requests/issues/4069
Codecov Report
@@ Coverage Diff @@
## master #254 +/- ##
=======================================
Coverage 67.01% 67.01%
=======================================
Files 12 12
Lines 573 573
Branches 91 91
=======================================
Hits 384 384
- Misses 162 163 +1
+ Partials 27 26 -1
Continue to review full report at Codecov.
|
|
v2.16.2 of requests fixes the backwards incompatibility |
Member
Author
|
Pull requests accepted to all acceptable versions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requests v2.15.x was released and found to be awfully broken.
Requests v2.16.x was released and is horribly backwards incompatible.
See also https://github.com/kennethreitz/requests/issues/4069
Related to gh-253