-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Add reference to PEP 610 #690
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ncoghlan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The text here should be the specification, rather than just a pointer to the PEP (similar to the way the core metadata is now described).
That way, future PEPs only need to describe what they're changing or adding, without needing to repeat everything that remained the same.
|
@ncoghlan ah ok, I was not sure since many other entries in the specifications page are merely pointers to the related PEP. At which point should we copy the spec here? I assume the PEP should move out of Draft state first? |
|
@sbidoul We used to use the PEPs as the primary reference, so we've just been opportunistically migrating them as they get updated for other reasons (e.g. PEP 566 was really about defining metadata 2.1, but it also migrated to using packaging.python.org as the main reference page for the core metadata spec). But yeah, for the initial draft, it makes sense to get it to Accepted before duplicating all the details over here. The key thing to add to the PEP is the long term URL you plan to use, and I think your suggestion of https://packaging.python.org/specifications/direct-url is a clear and sensible choice. |
@ncoghlan done in python/peps#1283 |
121209f to
cb1dc77
Compare
cb1dc77 to
7a7c3b1
Compare
|
I updated this PR with the full specification extracted from PEP 610. cc/ @ncoghlan @pradyunsg |
pradyunsg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've skimmed this to check the major bits, and not gone line by line. OTOH, I'm pretty sure that @sbidoul isn't gonna sneakily change a detail from their own PEP. 🙃
It can be added later when we have implementation experience.
|
@pradyunsg indeed, I only tweaked rst formatting (title underlines and roles), and adjusted the first few lines so it reads better. This reminds me, though, that I had said that I'd leave out the part about |
As proposed by @ncoghlan in https://discuss.python.org/t/draft-pep-recording-the-origin-of-distributions-installed-from-direct-url-references/1535/41?u=sbidoul