Do not emit serialization warning MISSING sentinel is present in a nested model
#12635
+21
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying pydantic-docs with
|
| Latest commit: |
b442ea4
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://4be9d1b1.pydantic-docs.pages.dev |
| Branch Preview URL: | https://vp-missing-warning.pydantic-docs.pages.dev |
davidhewitt
approved these changes
Dec 17, 2025
CodSpeed Performance ReportMerging #12635 will not alter performanceComparing Summary
|
davidhewitt
reviewed
Dec 18, 2025
| continue; | ||
| } | ||
| if value.is(missing_sentinel) { | ||
| has_missing_value = true; |
Contributor
There was a problem hiding this comment.
It might be more precise to add this to used_req_fields if field.required, instead of having a separate boolean? (e.g. would allow us still to warn if an optional field is missing and a required field is also missing)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12628.
Change Summary
Related issue number
Checklist