Add fraction #12442
Open
Add fraction #12442
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
CloseChoice
commented
Oct 23, 2025
| Model(a='wrong_format') | ||
| assert exc_info.value.errors(include_url=False) == [ | ||
| {'type': 'fraction_parsing', 'loc': ('a',), 'msg': 'Input is not a valid fraction', 'input': 'wrong_format'} | ||
| {'type': 'fraction_parsing', 'loc': ('a',), 'msg': 'Fraction input should be a tuple of two integers, a string or a Fraction object', 'input': 'wrong_format'} |
Contributor
Author
There was a problem hiding this comment.
Actually we don't check for a tuple of 2 ints, should we allow that?
CodSpeed Performance ReportMerging #12442 will not alter performanceComparing Summary
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Moves the Fraction validation to rust and makes sure that we handle it analogous to
Decimal. Also changes the serialization in Python mode ofFraction.Related issue number
#12286
This PR works in conjunction with pydantic/pydantic-core#1854 in pydantic-core
Checklist