Skip to content

Take frozen and validate_assignment configuration into account when caching setattr() handlers #12371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
Viicos wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Take frozen and validate_assignment configuration into account when caching setattr() handlers #12371

Viicos wants to merge 5 commits into from

Conversation

@Viicos
Copy link
Member

@Viicos Viicos commented Oct 9, 2025

Change Summary

Related issue number

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

@github-actions github-actions bot added the relnotes-fix Used for bugfixes. label Oct 9, 2025
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Oct 9, 2025 •
edited
Loading

Deploying pydantic-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: f5fc240
Status: ✅  Deploy successful!
Preview URL: https://1b51221a.pydantic-docs.pages.dev
Branch Preview URL: https://model-config-mutationg.pydantic-docs.pages.dev

View logs

@codspeed-hq
Copy link

codspeed-hq bot commented Oct 9, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #12371 will degrade performances by 19.18%

Comparing model-config-mutationg (f5fc240) with main (024e292)

Summary

❌ 1 regression
✅ 45 untouched

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
❌ test_setattr 89.6 µs 110.9 µs -19.18%

@Viicos Viicos force-pushed the model-config-mutationg branch from a38bfc0 to 54a5f79 Compare October 9, 2025 16:51
@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2025

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)		Lines missing
  pydantic
  main.py
Project Total  

This report was generated by python-coverage-comment-action

@Viicos Viicos force-pushed the model-config-mutationg branch from b2d39d2 to 0955e49 Compare October 9, 2025 18:36
@Viicos Viicos mentioned this pull request Oct 9, 2025
Closed
@Viicos Viicos force-pushed the model-config-mutationg branch from 11c6da3 to f5fc240 Compare October 9, 2025 19:06
@Viicos Viicos marked this pull request as draft October 9, 2025 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

relnotes-fix Used for bugfixes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Viicos