try moving definition inlining to pydantic-core #12294
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying pydantic-docs with
|
| Latest commit: |
5da3807
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://5842a178.pydantic-docs.pages.dev |
| Branch Preview URL: | https://dh-core-inline-definitions.pydantic-docs.pages.dev |
CodSpeed Performance ReportMerging #12294 will degrade performances by 5.67%Comparing Summary
Benchmarks breakdown
|
Contributor
Author
|
cc @Viicos this implements a first step in what I proposed by moving schema inlining to Rust. It seems like this is currently a decent win ~10%, however it could change a lot depending on what we can do with schema caching and config schema etc |
Contributor
Author
|
(serialization slowdown is because serializers don't inline in Rust yet on the draft core branch, also a few small test failures is not a surprise, these are mostly from asserting the schema type, which has changed, and also from a few changes to recursion handling which I think I can trivially prevent in core) |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
This is an experiment to see what happens if definition inlining is implemented inside
SchemaValidator. This should avoid the need to do it in Python (in theclean_schemafunction).Hoping this has performance benefits.
Not fully implemented yet, there's some test diffs due to changes in the recursion defenses, I think I know how to resolve.
For now I haven't particularly changed the Python code, just made
GenerateSchemanot bother running cleaning if there are no deferred discriminators to apply.Related issue number
N/A
Checklist