Skip to content
This repository was archived by the owner on Nov 4, 2020. It is now read-only.
This repository was archived by the owner on Nov 4, 2020. It is now read-only.

Library should return more data than True/False #224

Closed

Description

@sijis

Occasionally we run into issues (gitlab issue, code issue, ci issue, etc) and when troubleshooting calls, its difficult to troubleshoot a response to gitlab when the library returns only True or False.

I think it would be great to return json with a message on what it received from gitlab.
The information could be more useful and help in troubleshooting permission/code issues.

Activity

  1. Sudo-Kid commented on May 17, 2017

    @Sudo-Kid
    Contributor

    The new pattern that we have been implementing throws an error if the return result is not valid for that method. The exception contains the responses status code and body.

    Edit: I'm still working on getting all the old methods switched over to the new pattern witch will fix this issue. Though to keep backwards compatibility I'm adding new methods and calling them from the old ones. This will allow users to keep there old code and replace it with new code when/where they want to.

    This is also a duplicate of #193

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions