Skip to content

Fix errors discovered by PHPStan - #122

Merged
pwkip merged 1 commit into
pwkip:masterfrom
szepeviktor:patch-1
Aug 14, 2026
Merged

pwkip merged 1 commit into
pwkip:masterfrom
szepeviktor:patch-1

Conversation

@szepeviktor

@szepeviktor szepeviktor commented Apr 20, 2024 •

Copy link
Copy Markdown
Contributor

This PR includes two are hard errors.

This line could be improved

if ( ! isset( $_POST ) || empty( $_POST ) || ! isset( $_POST['wpcf7cf-settings-text'] ) ) {

if ( ! isset( $_POST['wpcf7cf-settings-text'] ) ) {

@pwkip
pwkip merged commit 1204733 into pwkip:master Aug 14, 2026
@pwkip

pwkip commented Aug 14, 2026

Copy link
Copy Markdown
Owner

Thanks — good catch, and the add_filter one is in for 2.7.12.

}, 2, 10 ) was indeed priority and accepted-args the wrong way round, so that filter had been running at priority 2 instead of 10 all along. The undeclared $steps property was fixed separately at some point before now.

Note: this repo is a generated mirror of the private PRO source tree, so the merge was recorded with -s ours — your commits and authorship are in the history, but the plugin files themselves are regenerated from PRO on each release.

pwkip added a commit that referenced this pull request Aug 14, 2026
* Fix the "deactivate the free plugin" admin notice rendering a second opening link tag instead of closing the first one. Make  the "Group name" label in the group tag generator translatable. Thanks [alexclassroom](#132)!
* Fix the `wpcf7_feedback_response` filter being registered with its priority and argument count swapped. Thanks [szepeviktor](#122)!
* Declare `Requires at least` and `Requires PHP` in the plugin header so WordPress can check them on activation. Thanks [IanDelMar](#119)!
* Raise the minimum WordPress version to 5.9.
@szepeviktor
szepeviktor deleted the patch-1 branch August 14, 2026 10:21
@pwkip

pwkip commented Aug 14, 2026

Copy link
Copy Markdown
Owner

Sorry for the ai-messages. Thanks the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants