pass temperature, pressure to modelchain sol pos call#936
Merged
CameronTStark merged 1 commit intopvlib:masterfrom Apr 17, 2020
Merged
pass temperature, pressure to modelchain sol pos call#936CameronTStark merged 1 commit intopvlib:masterfrom
CameronTStark merged 1 commit intopvlib:masterfrom
Conversation
This PR handles, the case where pressure or temp_air is not in weather, using the pvlib.tools._build_kwargs method, as keyword arguments. pvlib#893
Contributor
Author
|
@cwhanse How do I resolve the codecov error here? |
Contributor
Author
|
Since, the code successfully passes all checks except these two codecov tests. |
Member
Don't worry about it. codecov isn't hitting the 95% target due to |
Closed
Member
|
@Ahanmr just pinging you about this PR - can you add a line to the whatsnew v0.7.2 file, and add yourself to the Contributors section? Or if circumstances prevent you, I can do it for you. |
wholmgren
changed the title
Contributor
Author
|
Yes @cwhanse ! I'll do this right away! Thank you! |
CameronTStark
approved these changes
Apr 17, 2020
Contributor
CameronTStark
left a comment
CameronTStark
left a comment
There was a problem hiding this comment.
LGTM. Thanks @Ahanmr!
This was referenced Sep 23, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR handles, the case where pressure or temp_air is not in weather, using the pvlib.tools._build_kwargs method, as keyword arguments. #893
docs/sphinx/source/api.rstfor API changes.docs/sphinx/source/whatsnewfor all changes. Includes link to the GitHub Issue with:issue:`num`or this Pull Request with:pull:`num`. Includes contributor name and/or GitHub username (link with:ghuser:`user`).