@nappaillav are you planning on adding the bifacial code to this PR or did you want to split it into two PRs? My preference is a single PR since the trig functions are not explicitly tested and I don't see another near-term use for them.

@wholmgren Initially I thought of having separate pull requests, but I guess its better to combine both as you suggest.

There are few more steps in the process of completed the port of Purdue bifacial irradiance model, which are as follows

1. Description for the modules/ functions
2. Testing of the individual functions
3. Coding Style has to be corrected

Currently I'm updating the code for your perusal. So that you can suggest me

@cwhanse I have updated the description. If you can let me know if the implementation is fine by you, we can proceed further.
I also need help from you to completing the unit test.
I myself will do the write the test_codes, if you can provide me the test data (Input and output) it would be great.

@cwhanse I have updated the description. If you can let me know if the implementation is fine by you, we can proceed further.

The new bifacial functions should be added to pvlib.bifacial.py.

I'd suggest
pvlib.bifacial.irradiance_purdue
pvlib.bifacial.ground_reflected_purdue

Although I'm not fond of the ground_reflected name, it will move us ahead.

I also need help from you to completing the unit test.

Sure. Before we do that, we need to clean up the commit - it's not reviewable in current form.

There's a lot of leftover Matlab formalities that need to be dropped or formatted to pass Stickler.

There's a bunch of recent commits to pvlib master in other PRs that show up here as new code changes @wholmgren should this be addressed with a git rebase?

Yes

I will rebase and make sure the commit is clean

Closing due to merge of #717