add airspeed velocity config and performance tests#530
Closed
wholmgren wants to merge 2 commits intopvlib:masterfrom
Closed
add airspeed velocity config and performance tests#530wholmgren wants to merge 2 commits intopvlib:masterfrom
wholmgren wants to merge 2 commits intopvlib:masterfrom
Conversation
Member
|
Airspeed velocity (asv) is used in SciPy, I had to use it to create a benchmark for the vectorized Newton PR, but that's my only experience, seems useful but not sure if there's any standard on benchmarks |
8 tasks
6 tasks
Member
Author
|
closing in favor of #1049 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds configuration and test files for the airspeed velocity performance benchmarking tool.
This is new to me, but I'm putting it up here for feedback. I developed this while benchmarking #528 and #529. It seems useful. I'm not sure what the standard should be for merging this.
@mikofski do you have any experience using asv or similar tools? Anyone else?
In the long run, it would be ideal to set up a cloud service to automatically run these tests on the same (possibly virtual) hardware each time. As of now, I only want to consider running these tests locally.
docs/sphinx/source/api.rstfor API changes.docs/sphinx/source/whatsnewfile for all changes.git diff upstream/master -u -- "*.py" | flake8 --diffother:
benchmarks/benchmarksrather thanasv_bench/benchmarks(copied from xarray)