improve speed of Location.get_airmass#528
Merged
wholmgren merged 3 commits intopvlib:masterfrom Aug 14, 2018
Merged
Conversation
mikofski
requested changes
Aug 13, 2018
Member
There was a problem hiding this comment.
I think an even faster way to do this would be:
airmass = pd.DataFrame(
{'airmass_relative': airmass_relative,
'airmass_absolute': airmass_absolute},
index=solar_position.index)Nope I was wrong, it's already faster the way it is, and it keeps the correct order for all pythons b/c py2 dictionaries are unordered
Member
Author
|
@mikofski see the linked issue for timings. I slightly prefer this approach for style reasons. Happy to change if most people prefer the other approach. |
mikofski
approved these changes
Aug 13, 2018
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
docs/sphinx/source/api.rstfor API changes.docs/sphinx/source/whatsnewfile for all changes.git diff upstream/master -u -- "*.py" | flake8 --diff