use inferred window length in detect clearsky check#2550
Merged
kandersolar merged 3 commits intopvlib:mainfrom Sep 23, 2025
Merged
use inferred window length in detect clearsky check#2550kandersolar merged 3 commits intopvlib:mainfrom
kandersolar merged 3 commits intopvlib:mainfrom
Conversation
wholmgren
commented
Sep 23, 2025
| raise ValueError(f"Samples per window of {samples_per_window}" | ||
| " found. Each window must contain at least 3 data" | ||
| " points." | ||
| f" Window length of {window_length} found; increase" |
Member
Author
There was a problem hiding this comment.
flake8 complains about this semi colon despite it being within a string. notably ruff format does not complain about it. In any case I changed it to a period.
kandersolar
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
detect_clearskyshould use inferred window length when comparing to samples_per_window #2542docs/sphinx/source/referencefor API changes.docs/sphinx/source/whatsnewfor all changes. Includes link to the GitHub Issue with:issue:`num`or this Pull Request with:pull:`num`. Includes contributor name and/or GitHub username (link with:ghuser:`user`).remote-data) and Milestone are assigned to the Pull Request and linked Issue.