[DOC] Tooltips are always shown in light mode, even in dark mode.#2348
[DOC] Tooltips are always shown in light mode, even in dark mode.#2348kandersolar merged 8 commits intopvlib:mainfrom
Conversation
|
funny branch name 😂 |
|
Have we considered fixing this upstream instead of in pvlib? |
That would be nuts, although it does not seem easy since each theme (e.g. pydata-sphinx-theme) provides it's own way of specifying the theme colours (source comment). Anyways, they would surely welcome any PR in that regard. I wouldn't be able to do so, thou. So I propose mitigating this problem now this easy way and removing these changes in the future once it gets fixed (if so). |
|
@echedey-ls I see a mix of dark and light mode, is that expected?
|
|
Idk, but I was sure I got this right in some previous commit. In any case, here it is again. Apologies for the mail inbox notifications. |
RDaxini
left a comment
RDaxini
left a comment
There was a problem hiding this comment.
Seems to be working fine for me now, nice job @echedey-ls
kandersolar
left a comment
kandersolar
left a comment
There was a problem hiding this comment.
The CSS is simple and short enough, and the problem it addresses non-critical enough, that I'm okay with having a custom CSS file in our docs in lieu of an upstream fix.
Co-authored-by: Kevin Anderson <kevin.anderso@gmail.com>
4 participants
I know some people that would argue that's a health issue (me).
docs/sphinx/source/referencefor API changes.docs/sphinx/source/whatsnewfor all changes. Includes link to the GitHub Issue with:issue:`num`or this Pull Request with:pull:`num`. Includes contributor name and/or GitHub username (link with:ghuser:`user`).remote-data) and Milestone are assigned to the Pull Request and linked Issue.