update irradiance.reindl docs#2193
Merged
AdamRJensen merged 14 commits intopvlib:mainfrom Oct 4, 2024
Merged
Conversation
Member
Author
|
I have personally never used "BHI" before but I did swap out the I_hb and I_h since BHI/GHI etc are what are in the pvlib user guide. The original equation also already used "DHI", so it's consistent with the variable naming style. Overally, I think I probably lean towards using shorter symbols instead, like I_xx, but I see how DHI/GHI etc is easier to understand so I think it would help to hear other views on this. |
Member
Author
|
Marked as draft until #2191 has been addressed to avoid duplicate reviews due to similarities between the changes made in these PRs |
consistent reference style
add date to sentence
6 tasks
cwhanse
approved these changes
Oct 3, 2024
Thanks for the review Co-authored-by: Cliff Hansen <cwhanse@sandia.gov>
as per the paper (variable I_on)
…-python into update_reindl_docs
kandersolar
approved these changes
Oct 4, 2024
AdamRJensen
approved these changes
Oct 4, 2024
Member
|
Thanks @RDaxini! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
haydavies#2183, related to Klucher diffuse sky docstring inconsistency #1405docs/sphinx/source/whatsnewfor all changes. Includes link to the GitHub Issue with:issue:`num`or this Pull Request with:pull:`num`. Includes contributor name and/or GitHub username (link with:ghuser:`user`).remote-data) and Milestone are assigned to the Pull Request and linked Issue.Docs here