Closed
Conversation
echedey-ls
reviewed
Jul 19, 2024
Member
echedey-ls
left a comment
echedey-ls
left a comment
There was a problem hiding this comment.
Nice job with this implementation!
I miss a test of numpy input/output datatypes. Also, sphinx warns something near line 64 of the documentation, but I can't grasp what it could be.
Comment on lines
+861
to
+865
| The default is None. | ||
|
|
||
| coefficients : array-like, optional | ||
| User-defined coefficients, if not using one of the default coefficient | ||
| sets via the ``module_type`` parameter. The default is None. |
Member
| Average photon energy (APE, :math:`\varphi`) [eV] | ||
|
|
||
| band_depth : numeric | ||
| Depth of a spectral band, :math:`\varepsilon` [Wm:math:`^{-2}`] |
Member
There was a problem hiding this comment.
Suggested change
| Depth of a spectral band, :math:`\varepsilon` [Wm:math:`^{-2}`] | |
| Depth of a spectral band, :math:`\varepsilon` [W/m²] |
| out = spectrum.spectral_factor_daxini(apes, bands, | ||
| module_type=module_type) | ||
| assert isinstance(out, pd.Series) | ||
| assert np.allclose(expected, out, atol=1e-5) |
Member
There was a problem hiding this comment.
Suggested change
| assert np.allclose(expected, out, atol=1e-5) | |
| assert_allclose(out, expected, atol=1e-5) |
Member
Author
|
@echedey-ls Thanks for the review. |
Member
Author
|
Closed for now, see discussion in #2065 regarding availability of coefficients for more details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
docs/sphinx/source/referencefor API changes.docs/sphinx/source/whatsnewfor all changes. Includes link to the GitHub Issue with:issue:`num`or this Pull Request with:pull:`num`. Includes contributor name and/or GitHub username (link with:ghuser:`user`).remote-data) and Milestone are assigned to the Pull Request and linked Issue.This function calculates the spectral mismatch factor using the average photon energy and the depth of a water absorption band as inputs. Context: #2065