[DRAFT] Add more spectral responses#2038
Closed
echedey-ls wants to merge 11 commits intopvlib:mainfrom
Closed
Conversation
…vlib-python into duramat-eqe-dataset
Member
|
At the last GSoC meeting we had a group discussion on whether this PR should be merged. There was an general consensus that because there's nothing 'standard' about these curves, or any information that suggests that they are good generic representations of their specific technology, then it does not seem to fit within pvlib. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
docs/sphinx/source/referencefor API changes.docs/sphinx/source/whatsnewfor all changes. Includes link to the GitHub Issue with:issue:`num`or this Pull Request with:pull:`num`. Includes contributor name and/or GitHub username (link with:ghuser:`user`).remote-data) and Milestone are assigned to the Pull Request and linked Issue.Addresses the addition of more spectral responses, discussed both in #1963 and #2037. The data source is the duramat files linked by @adriesse.
Still draft before the general approach is discussed, but opened as a possible solution.
Dirty code with data analysis