Remove deprecated pvlib.iotools.read_srml_month_from_solardat function#1989
Merged
AdamRJensen merged 10 commits intopvlib:mainfrom Jun 6, 2024
Merged
Conversation
8 tasks
5 tasks
AdamRJensen
added
remote-data
Member
Author
|
@echedey-ls Would you be up for reviewing this PR? |
echedey-ls
approved these changes
Jun 2, 2024
Member
echedey-ls
left a comment
echedey-ls
left a comment
There was a problem hiding this comment.
Overall LGTM.
Surprisingly, adding a :py:func:... with parenthesis doesn't mess the docs.
Some overly-nitpicky comments below, feel free to ignore them.
Co-authored-by: Echedey Luis <80125792+echedey-ls@users.noreply.github.com>
Member
Author
|
Thank you very much for the review @echedey-ls I'll merge this on June 6th if no one objects. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[ ] Closes #xxxxdocs/sphinx/source/referencefor API changes.docs/sphinx/source/whatsnewfor all changes. Includes link to the GitHub Issue with:issue:`num`or this Pull Request with:pull:`num`. Includes contributor name and/or GitHub username (link with:ghuser:`user`).[ ] New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.remote-data) and Milestone are assigned to the Pull Request and linked Issue.The
pvlib.iotools.read_srml_month_from_solardatfunction was deprecated in 0.10.0 and should be removed in 0.11.0.