Replace pvfactors with solarfactors#1797
Merged
kandersolar merged 5 commits intopvlib:mainfrom Jul 5, 2023
Merged
Conversation
Member
Author
|
@pvlib/pvlib-core this is ready for review. I suggest we merge this and release v0.10.1. |
wholmgren
approved these changes
Jul 4, 2023
Member
wholmgren
left a comment
wholmgren
left a comment
There was a problem hiding this comment.
Works as expected!
$ conda create -n pvlib101 python=3.11
$ conda activate pvlib101
$ pip install "pvlib[optional] @ git+ssh://git@github.com/kandersolar/pvlib-python.git@solarfactors"
$ python
>>> import pvlib # this takes ~10-20 seconds in a new environment!?
>>> pvlib.__version__ # probably need a git fetch --tags
'0.9.2a3.dev106+g8d38d65'
>>> import solarfactors
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
ModuleNotFoundError: No module named 'solarfactors'
>>> import pvfactors
>>> pvfactors.__version__
'1.5.3'
AdamRJensen
approved these changes
Jul 4, 2023
Member
AdamRJensen
left a comment
AdamRJensen
left a comment
There was a problem hiding this comment.
This is a bit complicated lingo: "pip install solarfactors installs a package that is still accessed in code with the original import pvfactors."
Also, I think most users would appreciate a more explicit reason for why we switched to pvfactors - i.e., state that pvfactors is not being maintained
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[ ] Tests added[ ] Updates entries indocs/sphinx/source/referencefor API changes.docs/sphinx/source/whatsnewfor all changes. Includes link to the GitHub Issue with:issue:`num`or this Pull Request with:pull:`num`. Includes contributor name and/or GitHub username (link with:ghuser:`user`).[ ] New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.remote-data) and Milestone are assigned to the Pull Request and linked Issue.pvfactors_timeseriesdocstringI've got a first release of solarfactors up on PyPI, with the important feature of not requiring
pvlib<0.10. Other thanpip installing a different name, it should be a transparent replacement for pvfactors as far as pvlib is concerned. So hopefully just by changing the dependency name, the tests and docs build should pass without any other changes being needed.If so, I think we could proceed with making a v0.10.1 release with this update.