spectral_factor_firstsolar: rename pw to precipitable_water#1768
Merged
kandersolar merged 4 commits intopvlib:mainfrom Jun 15, 2023
Merged
spectral_factor_firstsolar: rename pw to precipitable_water#1768kandersolar merged 4 commits intopvlib:mainfrom
spectral_factor_firstsolar: rename pw to precipitable_water#1768kandersolar merged 4 commits intopvlib:mainfrom
Conversation
Closed
kandersolar
added a commit
to Jacc0027/pvlib-python
that referenced
this pull request
Jun 12, 2023
- reorder and rename parameters to match pvlib#1768 - remove reference parameters - shorten/simplify docstring - restructure calculation to be more readable
AdamRJensen
reviewed
Jun 14, 2023
Member
AdamRJensen
left a comment
AdamRJensen
left a comment
There was a problem hiding this comment.
precipitable_water should be also added to the Variables and Symbols.
| @@ -317,6 +310,14 @@ def spectral_factor_firstsolar(pw, airmass_absolute, module_type=None, | |||
| modules with very similar quantum efficiency should be similar, | |||
| in most cases limiting the need for module specific coefficients. | |||
|
|
|||
Member
There was a problem hiding this comment.
When did we start leaving spaces between parameter descriptions? 😯
kandersolar
commented
Jun 15, 2023
Member
Author
kandersolar
left a comment
kandersolar
left a comment
There was a problem hiding this comment.
precipitable_water should be also added to the Variables and Symbols.
It was added in #1623: 50e1998#diff-c687fd096ceeeeaebdf4846d37b19d06e6a6c9c409a47e89bbfa3e23446ffa42
AdamRJensen
approved these changes
Jun 15, 2023
wholmgren
approved these changes
Jun 15, 2023
Member
wholmgren
left a comment
wholmgren
left a comment
There was a problem hiding this comment.
I don't think the kwarg change is worth a deprecation. I'd consider removing them too.
kandersolar
added a commit
that referenced
this pull request
Jun 23, 2023
* Update atmosphere.py * Update atmosphere.py * Update atmosphere.py * Update atmosphere.py * Merge branch 'Spectral-corrections' of https://github.com/Jacc0027/pvlib-python into Spectral-corrections * Update atmosphere.py * Update atmosphere.py * Update atmosphere.py * Update atmosphere.py * Update atmosphere.py * Update atmosphere.py * Update atmosphere.py * Update atmosphere.py * Update atmosphere.py * Update atmosphere.py * Update atmosphere.py * Update atmosphere.py * Update atmosphere.py * Update atmosphere.py * Update atmosphere.py * Update atmosphere.py * Update atmosphere.py * Update atmosphere.py * Update atmosphere.py * Update atmosphere.py * Update atmosphere.py * Update atmosphere.py * Update pvlib/atmosphere.py Co-authored-by: Kevin Anderson <57452607+kanderso-nrel@users.noreply.github.com> * relocation of parameter descriptions according to the order of input parameters * Update api.rst Adding atmosphere.AM_AOD_PW_spectral correction as requested in #1296 * remove input screening * move reference values to be optional parameters * fix implementation issues * first cut at tests using file from Jacc0027 * CI correction. Line #215 * Update test_atmosphere.py * Update test_atmosphere.py * Update test_atmosphere.py * Update atmosphere.py * Update atmosphere.py * Update atmosphere.py * Update atmosphere.py * Testing tests * Update test_atmosphere.py * Update test_atmosphere.py * Update test_atmosphere.py * Update test_atmosphere.py * Update test_atmosphere.py * Update atmosphere.py * Test Review * Update atmosphere.py * Update test_atmosphere.py * Update test_atmosphere.py * Update test_atmosphere.py * Update test_atmosphere.py * Update atmosphere.py * Update atmosphere.py * Update atmosphere.py * Update atmosphere.py * Update test_atmosphere.py * Update atmosphere.py * Update test_atmosphere.py * Update test_atmosphere.py * Update test_atmosphere.py * Update test_atmosphere.py * Update test_atmosphere.py * Update pvlib/atmosphere.py Co-authored-by: Cliff Hansen <cwhanse@sandia.gov> * Update atmosphere.py Added the requested changes * Update atmosphere.py Fixed 2 blank line errors. * Update test_atmosphere.py Updated test function name to: caballero_spectral_correction * Update api.rst Updated the atmosphere function name from AM_AOD_PW_spectral_correction to caballero_spectral_correction * Update test_atmosphere.py Updated some functions calls from AM_AOD_PW_spectral_correction to caballero_spectral_correction * Update atmosphere.py Updated the logic to show errors. * Update pvlib/atmosphere.py Co-authored-by: Cliff Hansen <cwhanse@sandia.gov> * Update pvlib/atmosphere.py Co-authored-by: Cliff Hansen <cwhanse@sandia.gov> * Update pvlib/atmosphere.py Co-authored-by: Cliff Hansen <cwhanse@sandia.gov> * Update pvlib/atmosphere.py Co-authored-by: Cliff Hansen <cwhanse@sandia.gov> * Update pvlib/atmosphere.py Co-authored-by: Cliff Hansen <cwhanse@sandia.gov> * Update pvlib/atmosphere.py Co-authored-by: Cliff Hansen <cwhanse@sandia.gov> * Update atmosphere.py * Update atmosphere.py * Update atmosphere.py Trying to solve #814 and #817 issues. * Update atmosphere.py * Update api.rst * Delete api.rst * Update test_atmosphere.py * Update atmosphere.py * Update test_atmosphere.py * Update atmosphere.py * Update test_atmosphere.py * Update test_atmosphere.py * Update test_atmosphere.py * Update test_atmosphere.py * Update test_atmosphere.py * Update test_atmosphere.py * update function logic and get tests working * Update atmosphere.py Updated both "TODO" issues. * Update atmosphere.py * Update v0.9.6.rst Added caballero spectral correction as a new function. * Update airmass_atmospheric.rst Added a new function: atmosphere.caballero_spectral_correction * Update pvlib/atmosphere.py Co-authored-by: Anton Driesse <anton.driesse@pvperformancelabs.com> * rename function and move to pvlib.spectrum following the conventions set out in #1628 * misc cleanup - reorder and rename parameters to match #1768 - remove reference parameters - shorten/simplify docstring - restructure calculation to be more readable --------- Co-authored-by: Kevin Anderson <57452607+kanderso-nrel@users.noreply.github.com> Co-authored-by: Kevin Anderson <kevin.anderson@nrel.gov> Co-authored-by: Cliff Hansen <cwhanse@sandia.gov> Co-authored-by: Anton Driesse <anton.driesse@pvperformancelabs.com> Co-authored-by: Kevin Anderson <kevin.anderso@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[ ] Closes #xxxx[ ] Tests added[ ] Updates entries indocs/sphinx/source/referencefor API changes.docs/sphinx/source/whatsnewfor all changes. Includes link to the GitHub Issue with:issue:`num`or this Pull Request with:pull:`num`. Includes contributor name and/or GitHub username (link with:ghuser:`user`).[ ] New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.remote-data) and Milestone are assigned to the Pull Request and linked Issue.spectral_factor_firstsolar(formerlyfirst_solar_spectral_correction) has apwparameter. This PR renames it toprecipitable_waterfor consistency with the rest of pvlib.