ADR PV efficiency model from pvpltools-python (take 2)#1602
ADR PV efficiency model from pvpltools-python (take 2)#1602kandersolar merged 23 commits intopvlib:mainfrom adriesse:eta2
Conversation
|
FYI: I messed up my branch so I started over. |
|
Looking forward to some reviews... |
…nces, plus make stickler happy again.
|
Now that the tests pass again I'm going to leave this alone for a few days so reviewers don't have to aim for a moving target. I'd be happy to receive general (non-code) comments on the gallery examples as well. |
|
@kdebrab would you be interested in reviewing? |
|
Hi @adriesse thanks for this. I'll try to take a look at this asap. |
|
@nicolasholland would you be interested in reviewing? |
kandersolar
left a comment
kandersolar
left a comment
There was a problem hiding this comment.
FYI gallery section ordering is configurable, but I suggest leaving that for the future. https://sphinx-gallery.github.io/stable/configuration.html#sorting-gallery-subsections
Kevin's bug observations and identifications. :) Co-authored-by: Kevin Anderson <kevin.anderson@nrel.gov>
kandersolar
left a comment
kandersolar
left a comment
There was a problem hiding this comment.
LGTM other than a what's new entry and a couple minor points below. @mikofski do you still want to review?
|
Thanks Kevin. I just left a few things open for other reviewer(s) to comment on/react to before finalizing. |
cwhanse
left a comment
cwhanse
left a comment
There was a problem hiding this comment.
We need to correct the pv_modeling.rst file to inspect the documentation pages.
Co-authored-by: Cliff Hansen <cwhanse@sandia.gov>
|
I'm puzzled. The documentation preview showed links to the examples in the API section, but I don't see them in the current version... should I open an issue? |
4 participants
docs/sphinx/source/referencefor API changes.docs/sphinx/source/whatsnewfor all changes. Includes link to the GitHub Issue with:issue:`num`or this Pull Request with:pull:`num`. Includes contributor name and/or GitHub username (link with:ghuser:`user`).remote-data) and Milestone are assigned to the Pull Request and linked Issue.