Removing the 'closed' kwarg from pd.date_range in gallery examples #1540
Merged
kandersolar merged 5 commits intopvlib:masterfrom Aug 29, 2022
Merged
Removing the 'closed' kwarg from pd.date_range in gallery examples #1540kandersolar merged 5 commits intopvlib:masterfrom
kandersolar merged 5 commits intopvlib:masterfrom
Conversation
Contributor
Author
|
I've fixed the problems in my last pull request and add it here. |
cwhanse
approved these changes
Aug 28, 2022
Member
cwhanse
left a comment
cwhanse
left a comment
There was a problem hiding this comment.
Fixing a few format issues for you
docs/examples/solar-tracking/plot_single_axis_tracking_on_sloped_terrain.py
Outdated
Show resolved
Hide resolved
cwhanse
reviewed
Aug 28, 2022
docs/examples/solar-tracking/plot_single_axis_tracking_on_sloped_terrain.py
Outdated
Show resolved
Hide resolved
kandersolar
approved these changes
Aug 29, 2022
Member
kandersolar
left a comment
kandersolar
left a comment
There was a problem hiding this comment.
Thanks @joaoguilhermeS!
FYI it is better, and probably easier, to revise an existing PR than to make new ones from scratch. We can help with that next time if you need it :) And thanks again!
kandersolar
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[ ] Closes #xxxx[ ] Tests added[ ] Updates entries indocs/sphinx/source/referencefor API changes.docs/sphinx/source/whatsnewfor all changes. Includes link to the GitHub Issue with:issue:`num`or this Pull Request with:pull:`num`. Includes contributor name and/or GitHub username (link with:ghuser:`user`).remote-data) and Milestone are assigned to the Pull Request and linked Issue.