Skip to content

Fix PyPI deploy workflow#1532

Merged
kandersolar merged 1 commit intopvlib:masterfrom
kandersolar:deploy
Aug 17, 2022
Merged

Fix PyPI deploy workflow#1532
kandersolar merged 1 commit intopvlib:masterfrom
kandersolar:deploy

Conversation

@kandersolar
Copy link
Member

@kandersolar kandersolar commented Aug 17, 2022

  • Closes #xxxx
  • I am familiar with the contributing guidelines
  • Tests added
  • Updates entries in docs/sphinx/source/reference for API changes.
  • Adds description and name entries in the appropriate "what's new" file in docs/sphinx/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
  • New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.
  • Pull request is nearly complete and ready for detailed review.
  • Maintainer: Appropriate GitHub Labels (including remote-data) and Milestone are assigned to the Pull Request and linked Issue.

@wholmgren tagged v0.9.2-alpha.1 yesterday (#1483 (comment)) but the deploy workflow run for that commit skipped the PyPI upload step. I think, due to an error I made in #1306, the problem is that the workflow was triggered only by the push, not the tag, so the github.ref was master and not v0.9.2-alpha.1 and that step was skipped. This PR introduces version tags as another trigger for that workflow, so the workflow should be run both on the initial push to master (skipping PyPI upload) and the subsequent version tag (activating the PyPI upload).

Would like to get this merged ASAP to not further delay evaluation of the build/install changes ahead of the final 0.9.2 release.

@kandersolar kandersolar added this to the 0.9.2 milestone Aug 17, 2022
@kandersolar kandersolar requested a review from wholmgren August 17, 2022 19:10
wholmgren
wholmgren approved these changes Aug 17, 2022
View reviewed changes
Copy link
Member

@wholmgren wholmgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for looking into this! I was confused because the workflow did still run, but I didn't realize that it would run with a different github.ref depending on the settings in on. How about you go ahead and merge and then test it?

@kandersolar kandersolar merged commit 798799a into pvlib:master Aug 17, 2022
@kandersolar kandersolar deleted the deploy branch August 17, 2022 19:19
@kandersolar
Copy link
Member Author

kandersolar commented Aug 17, 2022 •
edited
Loading

Seems to have worked: https://github.com/pvlib/pvlib-python/runs/7886150625?check_suite_focus=true and https://pypi.org/project/pvlib/0.9.2a2/

The logs reveal a new issue:

Warning: You are using "pypa/gh-action-pypi-publish@master". The "master" branch of this project has been sunset and will not receive any updates, not even security bug fixes. Please, make sure to use a supported version. If you want to pin to v1 major version, use "pypa/gh-action-pypi-publish@release/v1". If you feel adventurous, you may opt to use use "pypa/gh-action-pypi-publish@unstable/v1" instead. A more general recommendation is to pin to exact tags or commit shas.

I'll just piggyback that one on #1483.

(and thanks for the fast review!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wholmgren wholmgren wholmgren approved these changes

Assignees

No one assigned

Labels

development_workflow

Projects

None yet

Milestone

0.9.2

Development

Successfully merging this pull request may close these issues.

2 participants

@kandersolar @wholmgren