Make leap_day=True default for PSM3 (deprecation)#1511
Merged
AdamRJensen merged 5 commits intopvlib:masterfrom Aug 15, 2022
Merged
Make leap_day=True default for PSM3 (deprecation)#1511AdamRJensen merged 5 commits intopvlib:masterfrom
AdamRJensen merged 5 commits intopvlib:masterfrom
Conversation
kandersolar
reviewed
Aug 1, 2022
Member
kandersolar
left a comment
kandersolar
left a comment
There was a problem hiding this comment.
Needs a whatsnew entry too
AdamRJensen
added
remote-data
7 tasks
Member
Author
|
@pvlib/pvlib-maintainer This PR is ready for a second review if anyone wants to take a look |
cwhanse
approved these changes
Aug 5, 2022
Update whatsnew with suggestion from cwhanse Co-authored-by: Cliff Hansen <cwhanse@sandia.gov>
AdamRJensen
added
remote-data
This was referenced Mar 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[ ] Updates entries indocs/sphinx/source/referencefor API changes.[ ] Adds description and name entries in the appropriate "what's new" file indocs/sphinx/source/whatsnewfor all changes. Includes link to the GitHub Issue with:issue:`num`or this Pull Request with:pull:`num`. Includes contributor name and/or GitHub username (link with:ghuser:`user`).remote-data) and Milestone are assigned to the Pull Request and linked Issue.It has been decided to change the default value for the
leap_dayargument in theget_psm3function from False to True (see #1481). This PR adds a deprecation warning stating that the default will be changed toleap_day=Truein pvlib 0.11.